Skip to content

Conversation

mamico
Copy link

@mamico mamico commented Feb 18, 2025

This PR was initially created to implement the subpath option for monorepos—Git projects with Python packages in a subpath (such as those generated with cookieplone).

You can review the initial changes here:
Comparison Link

Additionally, I've added GitHub Actions (GHA) for automated testing (https://github.com/mamico/mr.developer/actions)

  • Document the subpath option
  • Add tests for subpath
  • Review and fix broken tests for Python > 3.7 (currently commented out)

@fschulze @mauritsvanrees A possible idea could be to move this project to the collective organization. What do you think?

@mamico mamico marked this pull request as ready for review February 18, 2025 16:44
Copy link
Collaborator

@mauritsvanrees mauritsvanrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I have been unable to make time for this the past months.

Thanks! I did not try it for real, but the change looks good.

Thanks for picking up gh-actions as well. They don't run yet though. I have added inline suggestions that might work. It would be fine with me to drop support for Python 3.8 and lower.

Locally the tests fail though, due to recent setuptools 80.2.0. And 80.0.0 gives problems with Buildout anyway, so we will want to avoid that as well. (I have PRs in zc.buildout ready for that.)

So in tox.ini in [base] deps please add this line:

    setuptools<80

Then it goes much better locally, once I install svn and mercurial. I see two failures on 3.12, but maybe that is something local, so it would be good to see the test result here on GitHub.

mamico and others added 4 commits June 4, 2025 22:35
Co-authored-by: Maurits van Rees <[email protected]>
Co-authored-by: Maurits van Rees <[email protected]>
Co-authored-by: Maurits van Rees <[email protected]>
Co-authored-by: Maurits van Rees <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants