-
Notifications
You must be signed in to change notification settings - Fork 56
Subpath #212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Subpath #212
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I have been unable to make time for this the past months.
Thanks! I did not try it for real, but the change looks good.
Thanks for picking up gh-actions as well. They don't run yet though. I have added inline suggestions that might work. It would be fine with me to drop support for Python 3.8 and lower.
Locally the tests fail though, due to recent setuptools 80.2.0. And 80.0.0 gives problems with Buildout anyway, so we will want to avoid that as well. (I have PRs in zc.buildout
ready for that.)
So in tox.ini
in [base] deps
please add this line:
setuptools<80
Then it goes much better locally, once I install svn and mercurial. I see two failures on 3.12, but maybe that is something local, so it would be good to see the test result here on GitHub.
Co-authored-by: Maurits van Rees <[email protected]>
Co-authored-by: Maurits van Rees <[email protected]>
Co-authored-by: Maurits van Rees <[email protected]>
Co-authored-by: Maurits van Rees <[email protected]>
This PR was initially created to implement the
subpath
option for monorepos—Git projects with Python packages in a subpath (such as those generated with cookieplone).You can review the initial changes here:
Comparison Link
Additionally, I've added GitHub Actions (GHA) for automated testing (https://github.com/mamico/mr.developer/actions)
@fschulze @mauritsvanrees A possible idea could be to move this project to the collective organization. What do you think?