Fix PublicValuesNames rule #796
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Which tests for the fact that the rule should not fire for nested functions because they are not public.
Fix false positive in case of nested function. The rule should not fire for nested functions because they are not public.
webwarrior-ws
added a commit
to webwarrior-ws/conventions
that referenced
this pull request
Dec 25, 2025
In runFshrapLint.fsx because it includes [1], that fixes bug in rule 49 (PublicValuesNames), which caused CI failure due to false positive on deleteAsset function in script deleteAssetsFromOldReleases.fsx. [1] fsprojects/FSharpLint#796
webwarrior-ws
added a commit
to webwarrior-ws/conventions
that referenced
this pull request
Dec 25, 2025
In runFshrapLint.fsx because it includes [1], that fixes bug in rule 49 (PublicValuesNames), which caused CI failure due to false positive on deleteAsset function in script deleteAssetsFromOldReleases.fsx. Contains failing CI. [1] fsprojects/FSharpLint#796
webwarrior-ws
added a commit
to webwarrior-ws/conventions
that referenced
this pull request
Dec 25, 2025
In runFshrapLint.fsx because it includes [1], that fixes bug in rule 49 (PublicValuesNames), which caused CI failure due to false positive on deleteAsset function in script deleteAssetsFromOldReleases.fsx. Contains failing CI. [1] fsprojects/FSharpLint#796
webwarrior-ws
added a commit
to webwarrior-ws/conventions
that referenced
this pull request
Dec 25, 2025
In runFshrapLint.fsx because it includes [1], that fixes bug in rule 49 (PublicValuesNames), which caused CI failure due to false positive on deleteAsset function in script deleteAssetsFromOldReleases.fsx. Contains failing CI. [1] fsprojects/FSharpLint#796
webwarrior-ws
added a commit
to webwarrior-ws/conventions
that referenced
this pull request
Dec 25, 2025
In runFshrapLint.fsx because it includes [1], that fixes bug in rule 49 (PublicValuesNames), which caused CI failure due to false positive on deleteAsset function in script deleteAssetsFromOldReleases.fsx. Contains failing CI. [1] fsprojects/FSharpLint#796
webwarrior-ws
added a commit
to webwarrior-ws/conventions
that referenced
this pull request
Dec 25, 2025
In runFshrapLint.fsx because it includes [1], that fixes bug in rule 49 (PublicValuesNames), which caused CI failure due to false positive on deleteAsset function in script deleteAssetsFromOldReleases.fsx. Contains failing CI. [1] fsprojects/FSharpLint#796
webwarrior-ws
added a commit
to webwarrior-ws/conventions
that referenced
this pull request
Dec 25, 2025
In runFshrapLint.fsx because it includes [1], that fixes bug in rule 49 (PublicValuesNames), which caused CI failure due to false positive on deleteAsset function in script deleteAssetsFromOldReleases.fsx. Contains failing CI. [1] fsprojects/FSharpLint#796
webwarrior-ws
added a commit
to webwarrior-ws/conventions
that referenced
this pull request
Dec 25, 2025
In runFshrapLint.fsx because it includes [1], that fixes bug in rule 49 (PublicValuesNames), which caused CI failure due to false positive on deleteAsset function in script deleteAssetsFromOldReleases.fsx. Contains failing CI. [1] fsprojects/FSharpLint#796
webwarrior-ws
added a commit
to webwarrior-ws/conventions
that referenced
this pull request
Dec 29, 2025
In runFshrapLint.fsx because it includes [1], that fixes bug in rule 49 (PublicValuesNames), which caused CI failure due to false positive on deleteAsset function in script deleteAssetsFromOldReleases.fsx. Contains failing CI. [1] fsprojects/FSharpLint#796
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed false positive in case of nested function. The rule should not fire for nested functions because they are not public.
Added a test for nested function case.