Skip to content

Fix PublicValuesNames rule #796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knocte merged 2 commits into from
Dec 22, 2025
Merged

Fix PublicValuesNames rule #796

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b1cb8f
PublicValuesNames: add test for nested function
webwarrior-ws Dec 18, 2025
6381063
PublicValuesNames: fix rule
webwarrior-ws Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/FSharpLint.Core/Rules/Conventions/Naming/PublicValuesNames.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ let private getIdentifiers (args:AstNodeRuleParams) =
| AstNode.Expression(SynExpr.ForEach(_, _, _, true, pattern, _, _, _)) ->
getPatternIdents AccessControlLevel.Private (getValueOrFunctionIdents args.CheckInfo) false pattern
| AstNode.Binding(SynBinding(_, _, _, _, attributes, _, valData, pattern, _, _, _, _, _)) ->
if not (isLiteral attributes || isExtern attributes) then
if not (isLiteral attributes || isExtern attributes || isNested args args.NodeIndex) then
match identifierTypeFromValData valData with
| Value | Function ->
let accessibility = getAccessControlLevel args.SyntaxArray args.NodeIndex
Expand Down
20 changes: 20 additions & 0 deletions tests/FSharpLint.Core.Tests/Rules/Conventions/Naming/PublicValuesNames.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,3 +94,23 @@ let (|Empty|_|) str =
"""

this.AssertNoWarnings()

let pascalCaseConfig = { config with Naming = Some NamingCase.PascalCase }

[<TestFixture>]
type TestConventionsPublicValuesNamesPascalCase() =
inherit TestAstNodeRuleBase.TestAstNodeRuleBase(PublicValuesNames.rule pascalCaseConfig)

[<Test>]
member this.``Nested function should not generate warning``() =
this.Parse """
module Program

[ "one" ]
|> Seq.iter (fun str ->
let someFunc bar = bar
someFunc str
)
"""

this.AssertNoWarnings()
Loading