[Repo Assist] Extract isFirstCharUppercase helper in CodePrinter#3282
Closed
github-actions[bot] wants to merge 1 commit intomainfrom
Closed
Conversation
Both UppercaseType and UppercaseExpr active patterns contained identical logic to check if a string's first character is uppercase. Extract into a shared helper to eliminate the duplication. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
/repo-assist , nitpick but I'm more in a phase of life where I would write |
28 tasks
Contributor
|
/repo-assist try again |
Contributor
Author
|
Pull request created: #3292
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This PR was created by Repo Assist, an automated AI assistant. All changes were reviewed and tested before submission.
Summary
Both
(|UppercaseType|LowercaseType|)and(|UppercaseExpr|LowercaseExpr|)inCodePrinter.fscontained identical inline logic to check whether a string's first character is uppercase:The two definitions were independent copies of the same logic. This PR extracts the shared predicate into a single module-level helper:
Both active patterns now delegate to this helper, reducing duplication.
Trade-offs
CodePrinter.fsis amodule rec, order of definitions doesn't matter — no structural rearrangement was needed.Test Status
Build: ✅ succeeded (
Build succeeded.)Tests: ✅ all 2737 passed, 7 skipped (
Passed! - Failed: 0, Passed: 2737, Skipped: 7)