[Repo Assist] Extract isFirstCharUppercase helper in CodePrinter (v2)

[github-actions]

🤖 This PR was created by Repo Assist, an automated AI assistant. All changes were reviewed and tested before submission.

This is a revised version of #3282, incorporating maintainer feedback.

Changes

Both (|UppercaseType|LowercaseType|) and (|UppercaseExpr|LowercaseExpr|) in CodePrinter.fs contained identical inline logic to check whether a string's first character is uppercase. This PR extracts the shared predicate into a single module-level helper:

let isFirstCharUppercase (v: string) =
    match Seq.tryHead v with
    | Some c -> Char.IsUpper c
    | None -> false

As requested, the implementation uses a match expression rather than a pipeline chain. Both active patterns now delegate to this helper.

Trade-offs

• Positive: single definition for the "first char uppercase?" check, easier to update if the logic changes.
• No behaviour change: the logic is identical; only the location and style of the definition has changed.

Closes #3282 (supersedes the previous attempt)

Test Status

Build: ✅ succeeded
Tests: ✅ all 2738 passed, 7 skipped

Generated by Repo Assist · ◷

To install this agentic workflow, run

gh aw add githubnext/agentics/workflows/repo-assist.md@346204513ecfa08b81566450d7d599556807389f

[nojaf]

/repo-assist format code

[github-actions]

Commit pushed: 1a75e77

Generated by Repo Assist