-
Notifications
You must be signed in to change notification settings - Fork 27
feat(accordion): close #152 add height transition #154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for fulldev-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Thanks for contributing @BuptStEve ! And Apologies for the late reply here. Will be faster now that the holidays are over. As for the implementation, I see 2 problems:
I think this has to do with transitioning a If it is not possible with vanilla css it might be better to rename this component to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
|
Oh you're right, I'll figure it out... |
Kapture.2026-01-08.at.13.04.11.mp4 |
silveltman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! very smooth now 💪🏻
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.
Note
Improves accordion open/close animations with height-based transitions using CSS utilities.
accordion-content.astro: addsh-0 group-open:h-autoandduration-200 ease-outfor smooth height expansion/collapseaccordion-item.astro: addsdetails-content:*transition utilities includingtransition-[height,content-visibility]and[interpolate-size:allow-keywords]accordion.astro: no functional changes (formatting only)Written by Cursor Bugbot for commit c2859ee. This will update automatically on new commits. Configure here.