Skip to content

Conversation

@BuptStEve
Copy link
Contributor

@BuptStEve BuptStEve commented Dec 20, 2025

Summary by CodeRabbit

  • Style
    • Improved accordion component animations with enhanced height transitions for smoother open and close interactions.

✏️ Tip: You can customize this high-level summary in your review settings.


Note

Improves accordion open/close animations with height-based transitions using CSS utilities.

  • accordion-content.astro: adds h-0 group-open:h-auto and duration-200 ease-out for smooth height expansion/collapse
  • accordion-item.astro: adds details-content:* transition utilities including transition-[height,content-visibility] and [interpolate-size:allow-keywords]
  • accordion.astro: no functional changes (formatting only)

Written by Cursor Bugbot for commit c2859ee. This will update automatically on new commits. Configure here.

@netlify
Copy link

netlify bot commented Dec 20, 2025

Deploy Preview for fulldev-ui ready!

Name Link
🔨 Latest commit 7b67ca3
🔍 Latest deploy log https://app.netlify.com/projects/fulldev-ui/deploys/695f40095747f000088fdf97
😎 Deploy Preview https://deploy-preview-154--fulldev-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

coderabbitai[bot]

This comment was marked as outdated.

@fulldotdev fulldotdev deleted a comment from coderabbitai bot Dec 21, 2025
@silveltman
Copy link
Collaborator

Thanks for contributing @BuptStEve ! And Apologies for the late reply here. Will be faster now that the holidays are over.

As for the implementation, I see 2 problems:

  • The first time a page is loaded and the accordion is openen, it does not transition, it is instant.
  • when the transition works, it is very laggy and slow

I think this has to do with transitioning a h-auto. What do you think, and are you experiencing the same?

If it is not possible with vanilla css it might be better to rename this component to NativeAccordion since its based on the html dialog, and add another Accordion component which will be javascript based with smooth transitions.

Copy link
Collaborator

@silveltman silveltman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment above

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is being reviewed by Cursor Bugbot

Details

You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

@BuptStEve
Copy link
Contributor Author

Oh you're right, I'll figure it out...

@BuptStEve
Copy link
Contributor Author

@silveltman

Kapture.2026-01-08.at.13.04.11.mp4

Copy link
Collaborator

@silveltman silveltman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! very smooth now 💪🏻

@silveltman silveltman merged commit eeda1f6 into fulldotdev:main Jan 8, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants