Skip to content

feat(accordion): close #152 add height transition #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
silveltman merged 1 commit into from
Jan 8, 2026
Merged

feat(accordion): close #152 add height transition #154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/components/ui/accordion/accordion-content.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,11 @@ const slot = await Astro.slots.render("default")
slot?.trim().length > 0 && (
<div
data-slot="accordion-content"
class={cn("overflow-hidden text-sm", "pt-0 pb-4", className)}
class={cn(
"text-sm",
"pt-0 pb-4",
className
)}
{...props}
>
<Fragment set:html={slot} />
Expand Down
13 changes: 12 additions & 1 deletion src/components/ui/accordion/accordion-item.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,22 @@ const slot = await Astro.slots.render("default")
slot?.trim().length > 0 && (
<details
data-slot="accordion-item"
class={cn("border-b last:border-b-0", "group", className)}
class={cn(
"border-b last:border-b-0",
"group",
"details-content:h-0 open:details-content:h-auto",
"details-content:ease-out",
"details-content:duration-200",
"details-content:overflow-hidden",
"details-content:transition-discrete",
"details-content:transition-[height,content-visibility]",
className
)}
open={open}
{...props}
>
<Fragment set:html={slot} />
</details>
)
}

6 changes: 5 additions & 1 deletion src/components/ui/accordion/accordion.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,11 @@ const slot = await Astro.slots.render("default")

{
slot?.trim().length > 0 && (
<div data-slot="accordion" class={cn("w-full", className)} {...props}>
<div
data-slot="accordion"
class={cn("w-full [interpolate-size:allow-keywords]", className)}
{...props}
>
<Fragment set:html={slot} />
</div>
)
Expand Down