Skip to content

177 adjacency constraint#178

Merged
brendanreardon merged 64 commits intov1from
177-adjacency-constraint
Feb 19, 2026
Merged

177 adjacency constraint#178
brendanreardon merged 64 commits intov1from
177-adjacency-constraint

Conversation

@DanielPuthawala
Copy link
Collaborator

@DanielPuthawala DanielPuthawala commented Dec 1, 2025

Closes Issue #177 and Discussion #55.

This pull request serves to formally request review from the Cat-VRS product development group for approval of the
AdjacencyConstraint to draft maturity status and stage it for the next release of Cat-VRS.

Summary of the Pull Request.

Pull Request checklist:

  • Does the title of this Pull Request reference the corresponding Issue?
  • Is the branch validating against pre-commit hooks? Run pre-commit run --all-files from the root directory.
  • Is the branch passing tests? Run pytest tests/ from the root directory.

If the schema or examples were contributed to:

  • Were the schema def/ and json/ files recompiled and committed? Run cd schema; make all from the root directory.
  • If constraints or recipes were added, have they been added to the readthedocs? To do so, you can revise the appropriate file within docs/source/concepts/.
  • Has documentation been regenerated and committed? Run cd docs; make clean watch & from the root directory to compile documentation.
  • Have tests been created or updated?

@DanielPuthawala DanielPuthawala self-assigned this Dec 1, 2025
@DanielPuthawala DanielPuthawala requested a review from a team as a code owner December 1, 2025 14:31
@DanielPuthawala DanielPuthawala linked an issue Dec 1, 2025 that may be closed by this pull request
@brendanreardon brendanreardon marked this pull request as draft December 31, 2025 15:17
@brendanreardon
Copy link
Collaborator

brendanreardon commented Jan 17, 2026

  • MultipleKnownGeneElements removed and replaced with gks-core:ConceptSet
  • I was able to finally find a BCR::ABL1 fusion with breakpoints online, so that adjacencyEx1 was changed to use this illustrative example in members
  • Added Gene Fusion recipe, utilizing a slightly modified description from the VICC Fusion guidelines.
  • Regarding Bob Dolin's question about the use of a ConceptSet and categorical variant matching, this may be up to the implementer, I think. Given that the members of the concept set would be connected by an "OR" operator, I can imagine an implementer requiring either (i) if comparing two concept sets, require at least one gene concept to overlap, (ii) if comparing a concept set to a mappable concept, require the gene represented with a mappable concept to be present within the concept set, or (iii) match by default because, by definition, the concept set is non-exhaustive.

Current readthedocs 👇


Adjacency Constraint, with MultipleKnownGeneElements replaced with a gks-core:ConceptSet.
Screenshot 2026-01-17 at 12 06 01 PM

Gene Fusion Recipe
Screenshot 2026-01-17 at 12 08 49 PM

@brendanreardon
Copy link
Collaborator

Drafted Implementation Guidance for the AdjacencyConstraint. We currently do not have implementation guidance written for any of the Recipes, and this may be more appropriate as Implementation Guidance for the Gene Fusion Recipe.

Screenshot 2026-01-19 at 10 49 27 AM

@brendanreardon
Copy link
Collaborator

Additional changes made:

  • UnknownGeneElement renamed to UnspecifiedElement
  • Added functionalDomains to mimic requirement of VICC Gene Fusion Specification
  • Added 4th gene fusion example that includes functional domains

Reached out to Wes for feedback on Functional Domains implementation.

Copy link
Collaborator Author

@DanielPuthawala DanielPuthawala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh good catch!

@brendanreardon brendanreardon changed the base branch from 1.0 to v1 February 19, 2026 14:26
@brendanreardon brendanreardon force-pushed the 177-adjacency-constraint branch from 0481ff5 to 3fbc7a0 Compare February 19, 2026 18:37
@brendanreardon brendanreardon merged commit b3e61ca into v1 Feb 19, 2026
13 checks passed
@brendanreardon brendanreardon deleted the 177-adjacency-constraint branch February 19, 2026 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Draft Adjacency constraint

5 participants