Skip to content

fractional resource requirements for CWL 1.1 and 1.2 spec#230

Merged
vsmalladi merged 5 commits intodevelop-v1.2from
132-fractional
Mar 5, 2025
Merged

fractional resource requirements for CWL 1.1 and 1.2 spec#230
vsmalladi merged 5 commits intodevelop-v1.2from
132-fractional

Conversation

@vsmalladi
Copy link
Contributor

Closes #139

Copy link
Contributor

@uniqueg uniqueg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but would perhaps wait with merging until #219 is merged and develop is merged into develop-v1.2

vsmalladi and others added 3 commits November 14, 2024 19:48
Co-authored-by: Michael R. Crusoe <1330696+mr-c@users.noreply.github.com>
Co-authored-by: Michael R. Crusoe <1330696+mr-c@users.noreply.github.com>
Copy link
Contributor

@uniqueg uniqueg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vsmalladi: Should develop-v1.2 perhaps be rebased to current develop, given that this PR now has 133 commits with changes that are completely unrelated to the issue the PR attempts to address?

@vsmalladi
Copy link
Contributor Author

Yes merged develop back onto develop-v1.2 should solve this issue now

Copy link
Contributor

@uniqueg uniqueg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vsmalladi vsmalladi merged commit 56a54fa into develop-v1.2 Mar 5, 2025
6 checks passed
@vsmalladi vsmalladi deleted the 132-fractional branch March 5, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants