Merged
Conversation
Zehir
approved these changes
May 26, 2025
Collaborator
Zehir
left a comment
Zehir
left a comment
There was a problem hiding this comment.
LGTM but for some reason there is 2 tests that took 7 seconds but maybe it's expected ?
Collaborator
Author
Yeah it seems either 3D generation or rendering is really slow and we need to fix that but it's not on the scope of this PR. |
Collaborator
Author
|
It's probably the generation since the null layer one took the same time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #407. Needs #405 to pass all checks. This PR also updates the workflows' concurrency groups to allow tests to run at the same time.
TO-DO:
GridMapGaeaRenderertests