Add graph property to GaeaNodeResource and remove the old reference passed around#574
Merged
BenjaTK merged 1 commit intogaea-godot:2.0from Feb 15, 2026
Merged
Conversation
Zehir
force-pushed
the
add_graph_property
branch
from
397578d to
72ba562
Compare
… passed around in the methods.
Zehir
force-pushed
the
add_graph_property
branch
from
72ba562 to
a9bcb2c
Compare
Zehir
added
‼️breaking
BenjaTK
changed the title
graph property to GaeaNodeResource and remove the old reference passed around
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is the first step for #573
The idea here is to have a reference of the "owning" GareGraph on the GaeaNodeResource instead of passing around the reference. Because a lot of funtions inside GaeaNodeResource does use the reference and a GaeaNodeResource can have only one GareGraph.
Also simplify the reference to the graph inside the output node and parameter nodes. The methods was using the node->graph_edit->graph reference that is not defined on an exported game. Not sure how that was working before during gameplay
Note: Any custom nodes will need to remove the graph param so it's better to do that now than later