Modernize the ConfirmDialog composable to use GModal#22091
Open
ahmedhamidawan wants to merge 12 commits intogalaxyproject:devfrom
Open
Modernize the ConfirmDialog composable to use GModal#22091ahmedhamidawan wants to merge 12 commits intogalaxyproject:devfrom
ahmedhamidawan wants to merge 12 commits intogalaxyproject:devfrom
Conversation
ahmedhamidawan
added
kind/enhancement
area/UI-UX
kind/refactoring
57 tasks
ahmedhamidawan
force-pushed
the
b_modal_to_g_modal_simple_batch
branch
from
f1c544a to
abfc5ca
Compare
ahmedhamidawan
force-pushed
the
b_modal_to_g_modal_simple_batch
branch
from
abfc5ca to
5738f34
Compare
4 tasks
Member
Author
|
The failing should be unrelated. |
ConfirmDialog is now a modern vue component, instead of a legacy, options API, programmatically mounted component. This also updates selenium selectors to use the global confirm dialog. Part of the larger bootstrap to base components conversion effort in galaxyproject#21976 and galaxyproject#21956
Two edge cases are now handled in the confirm dialog system: - Concurrent calls: if `confirm()` is called while a dialog is already pending, the outstanding promise is resolved as `false` before the new dialog is shown. Content updates in place so there is no close/reopen flash. - Caller unmount: `useConfirmDialog()` now creates an AbortController and aborts it on `onUnmounted`, automatically cancelling any pending dialog. The `signal` is injected via the options so call sites need no changes. A `signal` field is also exposed on `ConfirmDialogOptions` for manual use. Co-Authored-By: Claude <noreply@anthropic.com>
Also, uses the confirm dialog in `ConfigureHeader` (extends the vitest as well)
ahmedhamidawan
force-pushed
the
b_modal_to_g_modal_simple_batch
branch
from
5738f34 to
df9a88f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ConfirmDialog is now a modern vue component, instead of a legacy, options API, programmatically mounted component.
This also updates selenium selectors to use the global confirm dialog.
Part of the larger bootstrap to base components conversion effort in #21976 and #21956
How to test the changes?
(Select all options that apply)
License