Adds build support for tvOS in macos-latest

[lupidan]

Changes

• Fixes pre-check to also support macOS
• Fixes Unity Hub module argument, to download the correct module for tvOS buildTarget

Successful Workflow Run Link

From my personal plugin repo, using my fork, you can see it successfully building for tvOS in macos-latest and later uploading it to Testflight: 🙌

https://github.com/lupidan/apple-signin-unity/actions/runs/15507807508/job/43664816746

Checklist

• Read the contribution guide and accept the
  code of conduct

Summary by CodeRabbit

• New Features

  • tvOS builds are now supported on both Windows and macOS operating systems.

• Bug Fixes

  • Updated the module parameter for tvOS builds to use the correct value, improving compatibility and build accuracy.

• Documentation

  • Error messages have been updated to accurately reflect the expanded OS support for tvOS builds.

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes update platform support and module argument mapping for tvOS builds. tvOS builds are now permitted on both Windows and macOS base operating systems, and the associated error message is updated. Additionally, the module argument for tvOS is changed from --module tvos to --module appletv.

Changes

File(s)	Change Summary
src/model/image-tag.ts	Expanded tvOS build support to include macOS; updated error message.
src/model/platform-setup/setup-mac.ts	Changed tvOS module argument from --module tvos to --module appletv.

Poem

A hop and a skip, a platform anew,
Now tvOS builds on Mac join the crew!
With modules renamed, the journey goes on,
From "tvos" to "appletv"—the old tag is gone.
Rabbits rejoice, for the code runs free,
On Windows and Mac, with platform glee!
🐇✨

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/model/image-tag.ts (1)

138-141: Simplify tvOS platform check and error message

The platform check and error text can be clearer and more maintainable:

1. Extract supported platforms into a constant, e.g.
   const SUPPORTED_TVOS_PLATFORMS = ['win32', 'darwin'];
2. Update the error message for consistency and remove “base OS” redundancy:

- if (process.platform !== 'win32' && process.platform !== 'darwin') {
-   throw new Error(`tvOS can only be built on Windows or macOS base OS`);
- }
+ if (!SUPPORTED_TVOS_PLATFORMS.includes(process.platform)) {
+   throw new Error(`tvOS builds are only supported on Windows or macOS.`);
+ }

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 819c251 and 7c273c4.

⛔ Files ignored due to path filters (3)

• dist/index.js is excluded by !**/dist/**
• dist/index.js.map is excluded by !**/dist/**, !**/*.map
• dist/licenses.txt is excluded by !**/dist/**

📒 Files selected for processing (2)

• src/model/image-tag.ts (1 hunks)
• src/model/platform-setup/setup-mac.ts (1 hunks)

🔇 Additional comments (1)

src/model/platform-setup/setup-mac.ts (1)

103-105: Correct mapping of tvOS Unity module parameter

The change from --module tvos to --module appletv now matches Unity Hub’s expected argument for the Apple TV target and is consistent with ImageTag suffix mappings. No further edits needed here.

[webbertakken]

LGTM

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 37.12%. Comparing base (819c251) to head (7c273c4).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
src/model/image-tag.ts	0.00%	2 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##             main     #709    +/-   ##
========================================
  Coverage   37.12%   37.12%            
========================================
  Files          77       77            
  Lines        3157     3157            
  Branches      659      623    -36     
========================================
  Hits         1172     1172            
- Misses       1838     1985   +147     
+ Partials      147        0   -147     

Files with missing lines	Coverage Δ
src/model/image-tag.ts	49.45% <0.00%> (ø)

... and 36 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.