Fix the InvalidSignature issues on RNQuickCrypto #2123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
gdorsi
changed the title
boorad
force-pushed
the
repro-rnquickcrypto-chat-signature-issue
branch
from
56df6bf to
211b129
Compare
Collaborator
|
@gdorsi I rebased, added a commit that makes DX a bit better for certain XCode versions, but didn't make any headway. After recent merges, I don't get the InvalidSignature error (maybe because you commented out my crap code in RNQuickCrypto). But I do get which seems to be from recent work on |
Collaborator
Author
|
@boorad Opened a PR to not throw when the profile is missing: #2155 The profile is missing probably because it wasn't synced before destroying the node (it can happen if the node is immediately closed). We can fix that, but for now I think we can just not throw if the profile is missing as it is not really needed anywhere by Jazz. |
…hat-signature-issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repro steps:
cd examples/chat-rn-expo && pnpm install && pnpm iosto start the example appif an account is already stored the loading should fail with an "InvalidSignature" errorFix: margelo/react-native-quick-crypto#690
After fix timings:
Also, there are some DX improvements for
iosbuilds, for when folks start using XCode 16.3 with Nitro Modulesfixes #2124