-
Notifications
You must be signed in to change notification settings - Fork 104
Fix the InvalidSignature issues on RNQuickCrypto #2123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
2229e5a
Create a repro for the InvalidSignature issues on RNQuickCrypto
gdorsi a8725ab
fix: XCode 16.3 bug fix, RNQuickCrypto remove dead code
boorad 519eda0
fix: skip profileID check
gdorsi 2217e12
clearUserCredentials
gdorsi d456a8c
fix: regex to stop dupes (for realz)
boorad 2858db7
fix: bump RNQC to version with verify fix
boorad 865b0e8
chore: remove debug stuffs
boorad 24d9a6b
chore: cleanup
gdorsi b0c2a5a
changeset
gdorsi 0641745
Merge remote-tracking branch 'origin/main' into repro-rnquickcrypto-c…
gdorsi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "jazz-react-native-core": patch | ||
| --- | ||
|
|
||
| Fix the InvalidSignature errors on RNQuickCrypto |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| const { withBuildProperties } = require("expo-build-properties"); | ||
| const { withDangerousMod } = require("@expo/config-plugins"); | ||
| const fs = require("fs/promises"); | ||
| const path = require("path"); | ||
|
|
||
| /** | ||
| * https://github.com/mrousavy/nitro/issues/422#issuecomment-2545988256 | ||
| */ | ||
| function withCustomIosMod(config) { | ||
| // Use expo-build-properties to bump iOS deployment target | ||
| config = withBuildProperties(config, { ios: { deploymentTarget: "16.0" } }); | ||
| // Patch the generated Podfile fallback to ensure platform is always 16.0 | ||
| config = withDangerousMod(config, [ | ||
| "ios", | ||
| async (modConfig) => { | ||
| const podfilePath = path.join( | ||
| modConfig.modRequest.platformProjectRoot, | ||
| "Podfile", | ||
| ); | ||
| let contents = await fs.readFile(podfilePath, "utf-8"); | ||
|
|
||
| // Check if the IPHONEOS_DEPLOYMENT_TARGET setting is already present | ||
| // We search for the key being assigned, e.g., config.build_settings['IPHONEOS_DEPLOYMENT_TARGET'] = | ||
| const deploymentTargetSettingExists = | ||
| /\.build_settings\s*\[\s*['"]IPHONEOS_DEPLOYMENT_TARGET['"]\s*\]\s*=/.test( | ||
| contents, | ||
| ); | ||
|
|
||
| if (!deploymentTargetSettingExists) { | ||
| // IPHONEOS_DEPLOYMENT_TARGET setting not found, proceed to add it. | ||
| contents = contents.replace( | ||
| /(post_install\s+do\s+\|installer\|[\s\S]*?)(\r?\n\s end\s*)$/m, | ||
| `$1 | ||
|
|
||
| # Expo Build Properties: force deployment target | ||
| # https://github.com/mrousavy/nitro/issues/422#issuecomment-2545988256 | ||
| installer.pods_project.targets.each do |target| | ||
| target.build_configurations.each do |config| | ||
| config.build_settings['IPHONEOS_DEPLOYMENT_TARGET'] = '16.0' | ||
| end | ||
| end | ||
| $2`, | ||
| ); | ||
| } | ||
|
|
||
| await fs.writeFile(podfilePath, contents); | ||
| return modConfig; | ||
| }, | ||
| ]); | ||
| return config; | ||
| } | ||
|
|
||
| module.exports = ({ config }) => { | ||
| return withCustomIosMod(config); | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.