-
Notifications
You must be signed in to change notification settings - Fork 1
Lint: Fix pyright errors in s3 module
#204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #204 +/- ##
==========================================
- Coverage 93.22% 89.03% -4.20%
==========================================
Files 30 33 +3
Lines 1372 1495 +123
==========================================
+ Hits 1279 1331 +52
- Misses 93 164 +71 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
d9179db to
2fd3378
Compare
2fd3378 to
049ca11
Compare
vivus-ignis
requested changes
Sep 25, 2025
3a78793 to
cf80d58
Compare
vivus-ignis
requested changes
Sep 26, 2025
b08d1dc to
dc3bd9f
Compare
vivus-ignis
approved these changes
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes mainly typing issues in the
s3module, mainly by explicitly casting or typing as Noneable.Which issue(s) this PR fixes:
Tracks #152