Add ros2 repo to gz-transport15 for zenoh package#96
Merged
Conversation
Signed-off-by: Ian Chen <ichen@openrobotics.org>
This was referenced Apr 18, 2025
Contributor
|
Using a docker image for rolling, the number of dependencies inside ROS for zenoh-cpp-vendor is pretty low: |
j-rivero
approved these changes
Apr 23, 2025
Contributor
|
This is approach is safe and can be used with a little cost as far as I can say. We would need a long term solution to provide the user with a default good binary distribution but this works until then. |
Contributor
|
As a side effect, we are not going to be in control of what version of Zenoh we are using. Not a blocker but something to consider. |
Contributor
Author
|
ok sounds good. I'll merge this in first so we have something to start testing with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #94
Use ros2 repo for zenoh packages instead of the eclipse-zenoh repo
Related PR: gazebosim/gz-transport#614