Skip to content

Find zenoh_cpp_vendor package from ROS 2#614

Merged
iche033 merged 5 commits intomain_find_zenohfrom
iche033/ros2_zenoh_cpp_vendor
May 1, 2025
Merged

Find zenoh_cpp_vendor package from ROS 2#614
iche033 merged 5 commits intomain_find_zenohfrom
iche033/ros2_zenoh_cpp_vendor

Conversation

@iche033
Copy link
Contributor

@iche033 iche033 commented Apr 18, 2025

🎉 New feature

Related PR:

Summary

If upstream zenohc and zenohcpp packages are not found, try look for zenoh_cpp_vendor packages from the ros2 repo

Test it

Tested with ros-rolling-zenoh-cpp-vendor package on noble and gz-transport is able to find zenohc and zenohcxx with this package.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <ichen@openrobotics.org>
@j-rivero
Copy link
Contributor

Tested with ros-rolling-zenoh-cpp-vendor package on noble and gz-transport is able to find zenohc and zenohcxx with this package.

Not related to code changes but I would prefer if we can pick an stable ROS release instead of Rolling so we avoid future version bumps of Zenoh that we can not control. If I checked it correctly, both rolling and jazzy are shiping Zenoh v1.3.2 ros2/rmw_zenoh@3e19ec7

Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033
Copy link
Contributor Author

iche033 commented Apr 25, 2025

Tested with ros-rolling-zenoh-cpp-vendor package on noble and gz-transport is able to find zenohc and zenohcxx with this package.

Not related to code changes but I would prefer if we can pick an stable ROS release instead of Rolling so we avoid future version bumps of Zenoh that we can not control. If I checked it correctly, both rolling and jazzy are shiping Zenoh v1.3.2 ros2/rmw_zenoh@3e19ec7

ok tested with ros-jazzy-zenoh-cpp-vendor package and that works too so added ros-jazzy-zenoh-cpp-vendor to packages-noble.apt

iche033 added 2 commits April 29, 2025 20:26
Signed-off-by: Ian Chen <ichen@openrobotics.org>
Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033
Copy link
Contributor Author

iche033 commented Apr 29, 2025

Added before_cmake.sh to set up ros env on ubuntu github actions. Noble CI should be working now, see cmake output in build

  -- defined lib target zenohcxx::zenohc for zenohc::lib
  -- Looking for zenohcxx and zenohc - found

Jammy CI is not officially supported so removed in #616

@iche033
Copy link
Contributor Author

iche033 commented Apr 29, 2025

As discussed in PMC meeting, we can move to ros-kilted-zenoh-cpp-vendor once Kilted is out, which is in ~1 month from now.

Signed-off-by: Ian Chen <ichen@openrobotics.org>
@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development Apr 30, 2025
@iche033
Copy link
Contributor Author

iche033 commented May 1, 2025

given that Ubuntu noble github action is working now, I'll merge this first so we can start testing.

@iche033 iche033 merged commit fe019a9 into main_find_zenoh May 1, 2025
6 checks passed
@iche033 iche033 deleted the iche033/ros2_zenoh_cpp_vendor branch May 1, 2025 20:06
@github-project-automation github-project-automation bot moved this from In review to Done in Core development May 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants