Skip to content

Add pre commit#675

Open
leander-dsouza wants to merge 2 commits intogazebosim:gz-gui9from
leander-dsouza:add_pre_commit
Open

Add pre commit#675
leander-dsouza wants to merge 2 commits intogazebosim:gz-gui9from
leander-dsouza:add_pre_commit

Conversation

@leander-dsouza
Copy link
Copy Markdown

🎉 New feature

Summary

I have added the following hooks as part of the pre-commit:

  • check-added-large-files
  • check-merge-conflict
  • check-xml
  • check-yaml
  • end-of-file-fixer
  • mixed-line-ending
  • trailing-whitespace

This prevents empty whitespace and additional newlines from registering as a separate commit during development.

Test it

  • Install pre-commit:
    sudo apt install pre-commit
  • Install pre-commit in the repository:
    cd ros_gz
    pre-commit install
  • Run pre-commit across all files:
    pre-commit run --all-files

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🎈 Release

Preparation for <X.Y.Z> release.

Comparison to <x.y.z>: https://github.com/gazebosim//compare/<LATEST_TAG_BRANCH>...<RELEASE_BRANCH>

Needed by <PR(s)>

Checklist

  • Asked team if this is a good time for a release
  • There are no changes to be ported from the previous major version
  • No PRs targeted at this major version are close to getting in
  • Bumped minor for new features, patch for bug fixes
  • Updated changelog
  • Updated migration guide (as needed)
  • Link to PR updating dependency versions in appropriate repository in gazebo-release (as needed):

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>
Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>
@github-actions github-actions bot added the 🏛️ ionic Gazebo Ionic label Apr 17, 2025
@leander-dsouza leander-dsouza marked this pull request as ready for review April 17, 2025 09:09
@azeey azeey added this to the Jetty Release milestone Jul 28, 2025
@azeey azeey moved this from Inbox to In progress in Core development Aug 7, 2025
@azeey azeey moved this from In progress to In review in Core development Aug 7, 2025
@azeey azeey removed this from the Jetty Release milestone Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏛️ ionic Gazebo Ionic

Projects

Status: In review

Development

Successfully merging this pull request may close these issues.

2 participants