Improve robustness to whitespace in gz_TEST#180
Merged
scpeters merged 1 commit intogz-plugin3from May 27, 2025
Merged
Conversation
The amount of indentation in `gz plugin --help` can vary, so add a helper function that looks for two substrings separated only by spaces and use it instead of hard-coding the expected amount of whitespace. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
ahcorde
approved these changes
May 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes #179
Summary
The amount of indentation in
gz plugin --helpcan vary, so add a helper function that looks for two substrings separated only by spaces and use it instead of hard-coding the expected amount of whitespace.Backported from 27be1bc in #175.
cc @traversaro
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.