Skip to content

Improve robustness to whitespace in gz_TEST #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
scpeters merged 1 commit into from
May 27, 2025
Merged

Improve robustness to whitespace in gz_TEST #180

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 27 additions & 13 deletions loader/src/gz_TEST.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,27 +57,41 @@ std::string custom_exec_str(std::string _cmd)
return result;
}

//////////////////////////////////////////////////
/// \brief Verify that two substrings are found within a larger string,
/// separated only by spaces
void verifySpaceSeparatedSubstrings(const std::string &_stringToSearch,
const std::string &_substring1,
const std::string &_substring2)
{
auto iterator1 = _stringToSearch.find(_substring1);
EXPECT_NE(std::string::npos, iterator1)
<< " failed to find \"" << _substring1 << "\" in:\n" << _stringToSearch;
ASSERT_LE(iterator1 + _substring1.size(), _stringToSearch.size());
auto iterator2 =
_stringToSearch.find_first_not_of(' ', iterator1 + _substring1.size());
EXPECT_NE(std::string::npos, iterator2);
ASSERT_LE(iterator2 + _substring2.size(), _stringToSearch.size());
EXPECT_EQ(_substring2, _stringToSearch.substr(iterator2, _substring2.size()));
}

//////////////////////////////////////////////////
/// \brief Check 'gz plugin --help'.
TEST(gzTest, IgnPluginHelp)
TEST(gzTest, GzPluginHelp)
{
// Path to gz executable
std::string gz = std::string(GZ_PATH);
std::string output = custom_exec_str(gz + " plugin --help");
EXPECT_NE(std::string::npos,
output.find("-i [--info] Get info about a plugin."))
<< output;
EXPECT_NE(std::string::npos,
output.find("-p [--plugin] TEXT Path to a plugin."))
<< output;
verifySpaceSeparatedSubstrings(
output, "-i [--info]", "Get info about a plugin.");
verifySpaceSeparatedSubstrings(
output, "-p [--plugin] TEXT", "Path to a plugin.");

output = custom_exec_str(gz + " plugin");
EXPECT_NE(std::string::npos,
output.find("-i [--info] Get info about a plugin."))
<< output;
EXPECT_NE(std::string::npos,
output.find("-p [--plugin] TEXT Path to a plugin."))
<< output;
verifySpaceSeparatedSubstrings(
output, "-i [--info]", "Get info about a plugin.");
verifySpaceSeparatedSubstrings(
output, "-p [--plugin] TEXT", "Path to a plugin.");
}

//////////////////////////////////////////////////
Expand Down
Loading