fix: incorrect err snippet position in esm files#1192
Merged
KuznetsovRoman merged 3 commits intomasterfrom Jan 21, 2026
Merged
Conversation
KuznetsovRoman
commented
Jan 19, 2026
| it("should patch webpack protocol sources", () => { | ||
| const sourceMap = { | ||
| version: 3, | ||
| version: 3 as unknown as string, |
Member
Author
There was a problem hiding this comment.
"js-source-map" has type issues
"version" should definitely be a number
commit: |
KuznetsovRoman
commented
Jan 20, 2026
Comment on lines
+10
to
+13
| const hasNoSourceMaps = fileContents.indexOf(JS_SOURCE_MAP_URL_COMMENT) === -1; | ||
| const isEsmFile = fileName.startsWith("file://"); | ||
|
|
||
| if (hasNoSourceMaps && !isEsmFile) { |
Member
Author
There was a problem hiding this comment.
Fixes invalid error snippet position with node22 (when files are imported as esm)
In this case, error stack position are correspond to source code positions already
shadowusr
approved these changes
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.