Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📦 Build Size Report |
✅ PR Checks CompleteTests Status: success All tests in |
There was a problem hiding this comment.
Pull request overview
This PR consolidates SEO meta tag management by moving meta tags from static HTML to router-managed configuration in src/routes/root.tsx. This enables dynamic meta tag generation for different routes while maintaining consistent SEO properties across the application.
- Moved meta tags (Open Graph, Twitter Card, keywords) from
index.htmlto the root route configuration - Added
og:urlandtwitter:urlmeta tags for better social media sharing - Enhanced site.webmanifest description to be more specific about Pittsburgh focus
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| index.html | Removed static meta tags (title, description, Open Graph, Twitter Card) and replaced with comment indicating router-managed content |
| src/routes/root.tsx | Added keywords meta tag and og:url/twitter:url properties to router-managed meta tags |
| public/site.webmanifest | Updated description to emphasize Pittsburgh music and arts focus |
| { property: 'og:title', content: SITE_NAME }, | ||
| { property: 'og:description', content: SITE_DESCRIPTION }, | ||
| { property: 'og:image', content: DEFAULT_IMAGE }, | ||
| { property: 'og:url', content: 'https://arcane.city/' }, |
There was a problem hiding this comment.
The URL is hardcoded instead of using the existing SITE_ORIGIN constant. This should be changed to content: SITE_ORIGIN + '/' to maintain consistency with the rest of the codebase and avoid hardcoding URLs. The SITE_ORIGIN constant is already imported from '../lib/seo' and handles both client-side and server-side rendering.
There was a problem hiding this comment.
@copilot open a new pull request to apply changes based on this feedback
| { name: 'twitter:title', content: SITE_NAME }, | ||
| { name: 'twitter:description', content: SITE_DESCRIPTION }, | ||
| { name: 'twitter:image', content: DEFAULT_IMAGE }, | ||
| { name: 'twitter:url', content: 'https://arcane.city/' }, |
There was a problem hiding this comment.
The URL is hardcoded instead of using the existing SITE_ORIGIN constant. This should be changed to content: SITE_ORIGIN + '/' to maintain consistency with the rest of the codebase and avoid hardcoding URLs. The SITE_ORIGIN constant is already imported from '../lib/seo' and handles both client-side and server-side rendering.
There was a problem hiding this comment.
@copilot open a new pull request to apply changes based on this feedback
|
@geoff-maddock I've opened a new pull request, #320, to work on those changes. Once the pull request is ready, I'll request review from you. |
|
@geoff-maddock I've opened a new pull request, #321, to work on those changes. Once the pull request is ready, I'll request review from you. |
No description provided.