-
Notifications
You must be signed in to change notification settings - Fork 0
Fixed seo meta for pages #319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -40,15 +40,18 @@ export const rootRoute = createRootRoute({ | |
| { charSet: 'utf-8' }, | ||
| { name: 'viewport', content: 'width=device-width, initial-scale=1' }, | ||
| { name: 'description', content: SITE_DESCRIPTION }, | ||
| { name: 'keywords', content: "events, music, concerts, art shows, venues, artists, live music, event discovery" }, | ||
| { property: 'og:site_name', content: SITE_NAME }, | ||
| { property: 'og:type', content: 'website' }, | ||
| { property: 'og:title', content: SITE_NAME }, | ||
| { property: 'og:description', content: SITE_DESCRIPTION }, | ||
| { property: 'og:image', content: DEFAULT_IMAGE }, | ||
| { property: 'og:url', content: 'https://arcane.city/' }, | ||
| { name: 'twitter:card', content: 'summary_large_image' }, | ||
| { name: 'twitter:title', content: SITE_NAME }, | ||
| { name: 'twitter:description', content: SITE_DESCRIPTION }, | ||
| { name: 'twitter:image', content: DEFAULT_IMAGE }, | ||
| { name: 'twitter:url', content: 'https://arcane.city/' }, | ||
|
||
| ], | ||
| }), | ||
| }); | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The URL is hardcoded instead of using the existing
SITE_ORIGINconstant. This should be changed tocontent: SITE_ORIGIN + '/'to maintain consistency with the rest of the codebase and avoid hardcoding URLs. TheSITE_ORIGINconstant is already imported from'../lib/seo'and handles both client-side and server-side rendering.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot open a new pull request to apply changes based on this feedback