Merged
Conversation
cmangeat
force-pushed
the
stac_harvester_doi
branch
from
80bdc5c to
1cd9180
Compare
jahow
approved these changes
Nov 7, 2025
Member
jahow
left a comment
jahow
left a comment
There was a problem hiding this comment.
Looking great, thanks! I made a comment but I think your approach is valid.
| <cit:identifier> | ||
| <mcc:MD_Identifier> | ||
| <mcc:code> | ||
| <gcx:Anchor xlink:href="{concat('https://doi.org/', sci_doi)}"><xsl:value-of select="sci_doi"/></gcx:Anchor> |
Member
There was a problem hiding this comment.
The extension that this field comes from (https://github.com/stac-extensions/scientific) says that a cite-as link should be present in the collection as well and give us a link to the actual DOI, without having to assemble this link ourselves. But in the sample used for the test this link doesn't exist, so I guess your approach is safer.
cmangeat
force-pushed
the
stac_harvester_doi
branch
from
f315a9f to
fa041a1
Compare
Member
|
Thank you! Btw we really urgently need some documentation for the STAC harvester |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is about improving STAC collection harvester (stac-to-iso19115-3.xsl conversion): add an online resource and cit:identifier for doi when available. (You can try it with stac collection like https://stacapi-cdos.apps.okd.crocc.meso.umontpellier.fr/collections, the stac harvester is a "URL simple" harvester, there is a "STAC collection" example configuration in harvester configuration panel).
Checklist
mainbranch, backports managed with labelREADME.mdfilespom.xmldependency management. Update build documentation with intended library use and library tutorials or documentationFunded by INRAE