Translations update from Hosted Weblate#3501
Conversation
Currently translated at 100.0% (802 of 802 strings) Co-authored-by: BSN ∞/21M ₿ <nc-kuttigfa@netcologne.de> Translate-URL: https://hosted.weblate.org/projects/getalby-lightning-browser-extension/getalby-lightning-browser-extension/de/ Translation: getAlby - lightning-browser-extension/getAlby - lightning-browser-extension
📝 WalkthroughWalkthroughA German translation string in the locale file is updated to modify the description of a password-related feature. The noun changes from "Passcode" to "Entsperrcode" and the sentence structure is slightly revised, with a trailing space added. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
src/i18n/locales/de/translation.json (1)
17-17: Consider terminology consistency in the same password setup block.Line 17 now uses „Entsperrcode“, while nearby keys in
welcome.set_passwordstill use „Passcode“. Unifying wording in this flow would improve UX consistency.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/i18n/locales/de/translation.json` at line 17, Update the translation key "description2" to use the same terminology as the other keys in the welcome.set_password flow (replace “Entsperrcode” with “Passcode” or vice versa to match the rest of the keys), ensuring wording consistency across welcome.set_password entries; locate and edit the "description2" value in src/i18n/locales/de/translation.json so it matches the term used in the other welcome.set_password keys.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/i18n/locales/de/translation.json`:
- Line 17: The translation value for key "description2" contains a trailing
space inside the string which can cause UI/snapshot diffs; locate the
"description2" entry in the de translation JSON and remove the trailing
whitespace character after the final period so the value ends with "Ändern." (or
the correct sentence ending) with no extra space, then save the file and run the
i18n/lint or snapshot tests to verify no further whitespace issues.
---
Nitpick comments:
In `@src/i18n/locales/de/translation.json`:
- Line 17: Update the translation key "description2" to use the same terminology
as the other keys in the welcome.set_password flow (replace “Entsperrcode” with
“Passcode” or vice versa to match the rest of the keys), ensuring wording
consistency across welcome.set_password entries; locate and edit the
"description2" value in src/i18n/locales/de/translation.json so it matches the
term used in the other welcome.set_password keys.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 5d972d68-ee3d-455a-b040-939a4ffb6dce
📒 Files selected for processing (1)
src/i18n/locales/de/translation.json
| }, | ||
| "description1": "Lege einen Passcode fest, um die Alby-Erweiterung in diesem Browser zu entsperren.", | ||
| "description2": "Der Passcode zum Entsperren kann nicht wiederhergestellt, aber geändert werden.", | ||
| "description2": "Der Entsperrcode kann nicht wiederhergestellt werden, aber geändert werden. ", |
There was a problem hiding this comment.
Remove the trailing whitespace in this translation value.
Line 17 ends with a space inside the string, which can cause subtle UI/snapshot inconsistencies.
✂️ Proposed fix
- "description2": "Der Entsperrcode kann nicht wiederhergestellt werden, aber geändert werden. ",
+ "description2": "Der Entsperrcode kann nicht wiederhergestellt werden, aber geändert werden.",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "description2": "Der Entsperrcode kann nicht wiederhergestellt werden, aber geändert werden. ", | |
| "description2": "Der Entsperrcode kann nicht wiederhergestellt werden, aber geändert werden.", |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@src/i18n/locales/de/translation.json` at line 17, The translation value for
key "description2" contains a trailing space inside the string which can cause
UI/snapshot diffs; locate the "description2" entry in the de translation JSON
and remove the trailing whitespace character after the final period so the value
ends with "Ändern." (or the correct sentence ending) with no extra space, then
save the file and run the i18n/lint or snapshot tests to verify no further
whitespace issues.
|
we can't just rename a term in one place, if at all we need to rename it everywhere. |
2 participants
Translations update from Hosted Weblate for getAlby - lightning-browser-extension/getAlby - lightning-browser-extension.
Current translation status:
Summary by CodeRabbit