-
-
Notifications
You must be signed in to change notification settings - Fork 101
feat: add status filter to projects table #1328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🔍 Deadcode AnalysisFound 6 unreachable functions in the backend. View detailsOnly remove deadcode that you know is 100% no longer used.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
13 files reviewed, 4 comments
ce50317 to
42dbcf9
Compare
|
I'm not sure I like this current solution. The desired behavior is to just get rid of stopped projects from the view, so a filter like usage on the images table would be better. |
Greptile's behavior is changing!From now on, if a review finishes with no comments, we will not post an additional "statistics" comment to confirm that our review found nothing to comment on. However, you can confirm that we reviewed your changes in the status check section. This feature can be toggled off in your Code Review Settings by deselecting "Create a status check for each PR". |
|
I couldnt get this to work, which then got me thinking the existsing status field should be able to work for this id think |
|
It is working for me but I'n all honesty I am now noticing it is janky starting it back up. If you stop a project externally it still shows the project under the running filter even though the status is correctly showing Stopped. I'll take another look. On a side note, not related to this issue, but selecting multiple filters does not properly work, it seems to behave as a first selected basis. Try selecting both option under images usage filter for an example |
|
Check that out is that what you meant? |
|
Docker images for this PR have been built successfully!
Built from commit 60248ab |
|
@cabaucom376 See the filter fix i made in #1391, this is cleaner to me , and should fix every page as well. |
|
This pull request has merge conflicts. Please resolve the conflicts so the PR can stay up-to-date and reviewed. |
closes #1163
Disclaimer Greptiles Reviews use AI, make sure to check over its work
Greptile Summary
This PR adds a status filter to the projects table, allowing users to filter projects by their status (running, stopped, or partially running). The implementation adds a
projectStatusquery parameter in the backend handler, implements SQL filtering with parameterized queries in the service layer, and integrates a faceted filter UI component in the frontend table toolbar. The filter values correctly match the backend status constants, and the implementation properly handles empty/missing filter values.Confidence Score: 5/5
Important Files Changed
projectStatusquery parameter and passes it to service layer via filters mapINclause, properly splits comma-separated valuesprojectStatusFilterswith correct status values matching backend constantsid: 'projectStatus'to status column definition to enable filtering