-
Notifications
You must be signed in to change notification settings - Fork 85
db-migrations: use pg for new migrations #1363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
alxndrsn
wants to merge
145
commits into
getodk:master
Choose a base branch
from
alxndrsn:prevent-new-migrations-with-knex
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
db-migrations: use pg for new migrations #1363
alxndrsn
wants to merge
145
commits into
getodk:master
from
alxndrsn:prevent-new-migrations-with-knex
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alxndrsn
commented
Jan 14, 2025
alxndrsn
commented
Jan 14, 2025
alxndrsn
commented
Jan 14, 2025
alxndrsn
commented
Jan 16, 2025
alxndrsn
commented
Jan 16, 2025
alxndrsn
commented
Jan 16, 2025
alxndrsn
commented
Jan 18, 2025
spwoodcock
pushed a commit
to spwoodcock/central-backend
that referenced
this pull request
May 12, 2025
Noticed while working on getodk#1363. Currently, when a postgres error has additional details, `run-migrations.js` will swallow these details. # Example ## migration ```js module.exports = { down: () => {}, up: db => db.raw(` INSERT INTO config (key) VALUES('a'); INSERT INTO config (key) VALUES('a'); `), } ``` ## logging - previous `master` ``` Error: INSERT INTO config (key) VALUES('a'); INSERT INTO config (key) VALUES('a') - duplicate key value violates unique constraint "config_pkey" ``` ## logging - this commit ``` Error: INSERT INTO config (key) VALUES('a'); INSERT INTO config (key) VALUES('a') - duplicate key value violates unique constraint "config_pkey" (Key (key)=(a) already exists.) ```
spwoodcock
pushed a commit
to spwoodcock/central-backend
that referenced
this pull request
May 12, 2025
Knex sorts migration files at https://github.com/knex/knex/blob/823c7b60f74fb16bcb8a8230afe1fea6673c2bd0/lib/migrate/sources/fs-migrations.js#L70 Encountered while working on getodk#1363
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewing
To reduce changeset to non-migrations:
git diff --ignore-all-space master -- $(git diff master --name-only | grep -v '^lib/model/migrations/')Before merging
Confirm that no (additional) migrations have been accidentally renamed:
TODO
master, resolve conflictsrenamequerytorawto simplify migration diffsconnectionObjectrename (knex: rename connection object #1364)connectrename (db-migrate: rename knex-specific functions #1372)lib/model/migrations/legacyto dissuade creating new knex-based migrationsWhat has been done to verify that this works as intended?
CI
Why is this the best possible solution? Were any other approaches considered?
Could use slonik instead, but seems better to tie implementation to a lower-level library, especially given concerns about upgrading to a more recent slonik (there are large API changes) and/or possibility of moving to an alternative to slonik.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Intended effects: none
Possible effects: break production databases
Does this change require updates to the API documentation? If so, please update docs/api.yaml as part of this PR.
Shouldn't require docs changes.
Before submitting this PR, please make sure you have:
make testand confirmed all checks still pass OR confirm CircleCI build passes