ci(coverage): make checks informational on release branches#541
Merged
Conversation
Make codecov status checks informational on main/release branches so they don't block Craft publishing, while keeping patch coverage blocking on PRs. - codecov.yml: add coverage.status config with project always informational and patch blocking by default (for PRs) - ci.yml: add sed step on push events to flip patch to informational on main/release branches
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
Contributor
Codecov Results 📊✅ 126 passed | Total: 126 | Pass Rate: 100% | Execution Time: 0ms 📊 Comparison with Base Branch
✨ No test changes detected All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 1028 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 96.02% 96.02% —%
==========================================
Files 185 185 —
Lines 25805 25805 —
Branches 0 0 —
==========================================
+ Hits 24777 24777 —
- Misses 1028 1028 —
- Partials 0 0 —Generated by Codecov Action |
BYK
added a commit
that referenced
this pull request
Mar 24, 2026
Follow-up to #541. Replaces the `sed`-based `codecov.yml` patching with the new `informational-patch` action input from getsentry/codecov-action (merged in getsentry/codecov-action#54). ### Changes - **`ci.yml`**: Remove the `sed` step, add `informational-patch: ${{ github.event_name == 'push' }}` to the codecov action - **`codecov.yml`**: Remove the `patch.default.informational` section (no longer needed) ### Behavior (unchanged) | Context | `codecov/project` | `codecov/patch` | |---------|-------------------|-----------------| | PR | informational | **blocking** | | `main` / `release/**` push | informational | informational |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make codecov status checks informational on
main/release/**branches so they don't block Craft publishing, while keeping patch coverage blocking on PRs.Changes
codecov.yml: Addcoverage.statusconfig withprojectalways informational andpatchblocking by default (for PRs)ci.yml: Addsedstep on push events to flippatchto informational onmain/release/**Behavior
codecov/projectcodecov/patchmain/release/**pushUses
getsentry/codecov-action'sinformationalconfig option. Since the action has no per-branch config support, the CI workflow conditionally editscodecov.ymlviasedon push events before running the action.