Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #473 +/- ##
==========================================
+ Coverage 80.35% 80.38% +0.03%
==========================================
Files 159 159
Lines 13465 13508 +43
Branches 1424 1437 +13
==========================================
+ Hits 10820 10859 +39
- Misses 2109 2110 +1
- Partials 536 539 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
noahsmartin
reviewed
Nov 14, 2025
noahsmartin
reviewed
Nov 14, 2025
| section_name = self._parse_lief_name(section.name) | ||
| section_infos.append(SectionInfo(name=section_name, size=section.size)) | ||
| is_zerofill = section.type == lief.MachO.Section.TYPE.ZEROFILL | ||
| section_infos.append(SectionInfo(name=section_name, size=section.size, is_zerofill=is_zerofill)) |
Contributor
There was a problem hiding this comment.
Can we just not append to section_infos at all if it's zero fill? That seems easier?
Member
Author
There was a problem hiding this comment.
spoke offline, basically want to keep this data unfiltered and have downstream consumers handle filtering stuff out
noahsmartin
reviewed
Nov 14, 2025
noahsmartin
approved these changes
Nov 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were a couple bugs that I was finally able to track down.
There are some slight counting discrepancies but very small now, only
7368over-counting bytes for the main Hackernews binary: