-
-
Notifications
You must be signed in to change notification settings - Fork 2
Fix various iOS treemap inaccuracies #473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 11 commits
c431714
638f838
377c987
fdbb80c
2896910
bf43af7
9212d33
d6164cd
b958f00
d72fb7e
7568f20
76fd204
d3d57a9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -563,8 +563,19 @@ def _extract_segments_info(self, binary: lief.MachO.Binary) -> List[SegmentInfo] | |
|
|
||
| section_infos: List[SectionInfo] = [] | ||
| for section in command.sections: | ||
| if section.segment.file_size == 0: | ||
| logger.warning( | ||
| "size.apple.skip_segment.zero_file_size", | ||
| extra={ | ||
| "segment_name": segment_name, | ||
| "section_name": section.name, | ||
| }, | ||
| ) | ||
| continue | ||
|
|
||
| section_name = self._parse_lief_name(section.name) | ||
| section_infos.append(SectionInfo(name=section_name, size=section.size)) | ||
| is_zerofill = section.type == lief.MachO.Section.TYPE.ZEROFILL | ||
| section_infos.append(SectionInfo(name=section_name, size=section.size, is_zerofill=is_zerofill)) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we just not append to section_infos at all if it's zero fill? That seems easier?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. spoke offline, basically want to keep this data unfiltered and have downstream consumers handle filtering stuff out |
||
|
|
||
| segments.append( | ||
| SegmentInfo( | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.