Skip to content

Conversation

noahsmartin
Copy link
Contributor

📜 Description

Fixed several obvious typos in Objective-C comment blocks across various .m files.

💡 Motivation and Context

This change improves the overall code quality and readability by correcting grammatical errors and misspellings in comments. It ensures that the documentation within the code is accurate and professional.

💚 How did you test it?

A systematic scan of all .m files was performed, prioritizing files with a higher number of comments. Each identified typo was manually reviewed for context and corrected. A broader scan was then conducted to catch any remaining issues.

📝 Checklist

You have to check all boxes before merging:

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

Slack Thread

Open in Cursor Open in Web

Copy link

cursor bot commented Aug 27, 2025

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

Copy link
Contributor

🚨 Detected changes in high risk code 🚨

High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:

  • Sources/Sentry/SentryUIViewControllerSwizzling.m

Copy link
Contributor

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Fix typos in obj c comments ([#5993](https://github.com/getsentry/sentry-cocoa/pull/5993))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description or adding a skip-changelog label.

Generated by 🚫 dangerJS against 974f543

Copy link

codecov bot commented Aug 27, 2025

❌ 3 Tests Failed:

Tests completed Failed Passed Skipped
28733 3 28730 88
View the top 3 failed test(s) by shortest run time
SentryTests.SentrySessionReplayIntegrationTests::testBufferReplayIgnoredBecauseSampleRateForCrash
Stack Traces | 0s run time
.../Integrations/SessionReplay/SentrySessionReplayIntegrationTests.swift:284 - Fulfilled inverted expectation "Replay to be captured".
SentryTests.SentrySessionReplayIntegrationTests::testBufferReplayIgnoredBecauseSampleRateForCrash
Stack Traces | 0s run time
.../Integrations/SessionReplay/SentrySessionReplayIntegrationTests.swift:284 - Fulfilled inverted expectation "Replay to be captured".
SentryTests.SentrySessionReplayIntegrationTests::testBufferReplayIgnoredBecauseSampleRateForCrash
Stack Traces | 0s run time
.../Integrations/SessionReplay/SentrySessionReplayIntegrationTests.swift:284 - Fulfilled inverted expectation "Replay to be captured".

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1235.69 ms 1260.19 ms 24.49 ms
Size 23.75 KiB 926.64 KiB 902.89 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
32e7197 1226.91 ms 1245.48 ms 18.56 ms
aa0b738 1236.78 ms 1253.08 ms 16.31 ms
fc6557e 1226.40 ms 1249.88 ms 23.48 ms
a9fac2e 1212.45 ms 1219.67 ms 7.22 ms
ea5a59b 1222.87 ms 1253.47 ms 30.60 ms
af7a86c 1220.82 ms 1243.36 ms 22.54 ms
cc02c0d 1234.69 ms 1247.15 ms 12.46 ms
2691350 1224.92 ms 1255.82 ms 30.90 ms
d23a1b1 1218.94 ms 1239.53 ms 20.60 ms
748df9d 1231.63 ms 1259.47 ms 27.84 ms

App size

Revision Plain With Sentry Diff
32e7197 23.75 KiB 866.69 KiB 842.94 KiB
aa0b738 23.74 KiB 872.75 KiB 849.00 KiB
fc6557e 23.75 KiB 866.68 KiB 842.93 KiB
a9fac2e 23.75 KiB 879.53 KiB 855.78 KiB
ea5a59b 23.75 KiB 874.46 KiB 850.71 KiB
af7a86c 23.74 KiB 926.65 KiB 902.90 KiB
cc02c0d 23.75 KiB 912.37 KiB 888.62 KiB
2691350 23.75 KiB 850.73 KiB 826.98 KiB
d23a1b1 23.75 KiB 913.64 KiB 889.88 KiB
748df9d 23.75 KiB 902.48 KiB 878.74 KiB

@noahsmartin noahsmartin closed this Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants