Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/Sentry/SentrySessionTracker.m
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ - (void)startSession
self.lastInForeground = [[[hub getClient] fileManager] readTimestampLastInForeground];

if (nil == self.lastInForeground) {
// Cause we don't want to track sessions if the app is in the background we need to wait
// Because we don't want to track sessions if the app is in the background we need to wait
// until the app is in the foreground to start a session.
SENTRY_LOG_DEBUG(@"App was in the foreground for the first time. Starting a new session.");
[hub startSession];
Expand Down
4 changes: 2 additions & 2 deletions Sources/Sentry/SentryUIViewControllerPerformanceTracker.m
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ - (void)startRootSpanFor:(UIViewController *)controller
[self.tracker getSpan:SENTRY_UNWRAP_NULLABLE(SentrySpanId, spanId)];

if (![vcSpan isKindOfClass:[SentryTracer self]]) {
// Since TTID and TTFD are meant to the whole screen
// Since TTID and TTFD are meant for the whole screen
// we will not track child view controllers
return;
}
Expand Down Expand Up @@ -416,7 +416,7 @@ - (void)viewControllerViewWillLayoutSubViews:(UIViewController *)controller
// (https://developer.apple.com/documentation/uikit/uiviewcontroller/1621510-viewwillappear),
// viewWillAppear should be called for before the UIViewController is added to the view
// hierarchy. There are some edge cases, though, when this doesn't happen, and we saw
// customers' transactions also proofing this. Therefore, we must also report the
// customers' transactions also proving this. Therefore, we must also report the
// initial display here, as the customers' transactions had spans for
// `viewWillLayoutSubviews`.
[self reportInitialDisplayForController:controller];
Expand Down
4 changes: 2 additions & 2 deletions Sources/Sentry/SentryUIViewControllerSwizzling.m
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ - (void)swizzleUIViewControllersOfImage:(NSString *)imageName

[self.imagesActedOnSubclassesOfUIViewControllers addObject:imageName];

// Swizzle all custom UIViewControllers. Cause loading all classes can take a few milliseconds,
// Swizzle all custom UIViewControllers. Because loading all classes can take a few milliseconds,
// the SubClassFinder does this on a background thread, which should be fine because the SDK
// swizzles the root view controller and its children above. After finding all subclasses of the
// UIViewController, we swizzles them on the main thread. Swizzling the UIViewControllers on a
Expand Down Expand Up @@ -336,7 +336,7 @@ - (void)swizzleViewControllerSubClass:(Class)class
return;
}

// This are the five main functions related to UI creation in a view controller.
// These are the five main functions related to UI creation in a view controller.
// We are swizzling it to track anything that happens inside one of this functions.
[self swizzleViewLayoutSubViews:class];
[self swizzleLoadView:class];
Expand Down
2 changes: 1 addition & 1 deletion Sources/Sentry/SentryWatchdogTerminationLogic.m
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ - (BOOL)isWatchdogTermination
}

// Restarting the app in development is a termination we can't catch and would falsely
// report watchdog termiations.
// report watchdog terminations.
if (previousAppState.isDebugging) {
return NO;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ + (SentryCrashVA_Block)argBlockWithFilters:(NSMutableArray *)filters andKeys:(NS
}
if (![entry conformsToProtocol:@protocol(SentryCrashReportFilter)]) {
SENTRY_LOG_ERROR(@"Not a filter: %@", entry);
// Cause next key entry to fail as well.
// Causes next key entry to fail as well.
return;
} else {
[filters addObject:entry];
Expand Down
Loading