ref: Remove deprecated app start option

[noahsmartin]

Fully removes "enableAppLaunchProfiling" which is removed in V9

#skip-changelog

Closes #6461

[codecov]

❌ 2 Tests Failed:

Tests completed	Failed	Passed	Skipped
4008	2	4006	34

View the top 3 failed test(s) by shortest run time

SentryTests.SentryWatchdogTerminationTrackerTests::testStart_StoresAppState

Stack Traces | 0s run time

.../Integrations/WatchdogTerminations/SentryWatchdogTerminationTrackerTests.swift:117 - XCTAssertEqual failed: ("1") is not equal to ("2")

iOS_ObjectiveC_UITests.LaunchUITests::testLaunch

Stack Traces | 0s run time

.../iOS-ObjectiveC/iOS-ObjectiveC-UITests/LaunchUITests.swift:12 - Application 'io.sentry.iOS-ObjectiveC' does not have a process ID

iOS_SwiftUI_UITests.LaunchUITests::testNoNewTransactionForSecondCallToBody

Stack Traces | 0s run time

.../iOS-SwiftUI/iOS-SwiftUI-UITests/LaunchUITests.swift:37 - Failed to tap "Form Screen" Button: Timed out while evaluating UI query.

To view more test analytics, go to the Test Analytics Dashboard
_{📋 Got 3 mins? Take this short survey to help us improve Test Analytics.}

[github-actions]

Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1212.31 ms	1246.08 ms	33.77 ms
Size	23.74 KiB	1021.45 KiB	997.70 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
7123d8e	1222.27 ms	1262.02 ms	39.76 ms
5258fb8	1207.92 ms	1234.51 ms	26.59 ms
07d7e83	1211.71 ms	1240.08 ms	28.37 ms
be882e4	1199.35 ms	1231.20 ms	31.86 ms
4e3915a	1230.02 ms	1258.90 ms	28.88 ms
7273bf4	1202.42 ms	1227.62 ms	25.21 ms
7bd90de	1233.48 ms	1249.47 ms	15.99 ms
f4f94f5	1216.24 ms	1247.94 ms	31.70 ms
7416ffc	1225.55 ms	1241.80 ms	16.25 ms
d7461dc	1233.69 ms	1255.29 ms	21.60 ms

App size

Revision	Plain	With Sentry	Diff
7123d8e	23.75 KiB	986.80 KiB	963.05 KiB
5258fb8	23.75 KiB	874.45 KiB	850.70 KiB
07d7e83	23.75 KiB	913.27 KiB	889.52 KiB
be882e4	23.75 KiB	946.69 KiB	922.94 KiB
4e3915a	23.75 KiB	858.69 KiB	834.94 KiB
7273bf4	23.75 KiB	908.01 KiB	884.26 KiB
7bd90de	23.75 KiB	933.33 KiB	909.58 KiB
f4f94f5	23.75 KiB	988.02 KiB	964.27 KiB
7416ffc	23.75 KiB	913.63 KiB	889.88 KiB
d7461dc	23.75 KiB	874.45 KiB	850.70 KiB

Previous results on branch: removeDeprecatedAppStart

Startup times

Revision	Plain	With Sentry	Diff
870406c	1219.41 ms	1241.37 ms	21.97 ms
23cd282	1219.63 ms	1247.42 ms	27.79 ms

App size

Revision	Plain	With Sentry	Diff
870406c	23.75 KiB	1021.46 KiB	997.71 KiB
23cd282	23.74 KiB	1021.45 KiB	997.71 KiB

[philprime]

LGTM, but is this option not used anywhere? I would expect some logic to be removed as well

[noahsmartin]

@philprime I was surprised as well, it seems like it was only retained to keep the public API from breaking