Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -481,7 +481,6 @@ extension SentrySDKWrapper {
return NSNumber(value: samplerValue)
}
}
options.enableAppLaunchProfiling = !SentrySDKOverrides.Profiling.disableAppStartProfiling.boolValue
#endif // !SDK_V9

if !SentrySDKOverrides.Profiling.disableUIProfiling.boolValue {
Expand Down
7 changes: 0 additions & 7 deletions Samples/iOS-ObjectiveC/iOS-ObjectiveC/AppDelegate.m
Original file line number Diff line number Diff line change
Expand Up @@ -68,13 +68,6 @@ - (BOOL)application:(UIApplication *)application
{
return @([env[@"--io.sentry.profilesSamplerValue"] floatValue]);
};
# pragma clang diagnostic pop
}

if (![args containsObject:@"--io.sentry.profiling.disable-app-start-profiling"]) {
# pragma clang diagnostic push
# pragma clang diagnostic ignored "-Wdeprecated-declarations"
options.enableAppLaunchProfiling = YES;
# pragma clang diagnostic pop
}
#endif // !SDK_V9
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -197,11 +197,7 @@ private extension ProfilingViewController {
profileAppStartsSwitch.isOn = v2Options.profileAppStarts
} else {
traceLifecycleSwitch.isOn = false
#if SDK_V9
profileAppStartsSwitch.isOn = false
#else
profileAppStartsSwitch.isOn = options.enableAppLaunchProfiling
#endif // !SDK_V9
}
}

Expand Down
16 changes: 0 additions & 16 deletions Sources/Sentry/Public/SentryOptions.h
Original file line number Diff line number Diff line change
Expand Up @@ -538,22 +538,6 @@ typedef void (^SentryProfilingConfigurationBlock)(SentryProfileOptions *_Nonnull
@property (nullable, nonatomic, copy) SentryProfilingConfigurationBlock configureProfiling;

# if !SDK_V9
/**
* @warning This is an experimental feature and may still have bugs.
* Set to @c YES to run the profiler as early as possible in an app launch, before you would
* normally have the opportunity to call @c SentrySDK.start . If @c profilesSampleRate is nonnull,
* the @c tracesSampleRate and @c profilesSampleRate are persisted to disk and read on the next app
* launch to decide whether to profile that launch.
* @warning If @c profilesSampleRate is @c nil then a continuous profile will be started on every
* launch; if you desire sampling profiled launches, you must compute your own sample rate to decide
* whether to set this property to @c YES or @c NO .
* @warning This property is deprecated and will be removed in a future version of the SDK. See
* @c SentryProfileOptions.startOnAppStart and @c SentryProfileOptions.lifecycle .
* @note Profiling is automatically disabled if a thread sanitizer is attached.
*/
@property (nonatomic, assign) BOOL enableAppLaunchProfiling DEPRECATED_MSG_ATTRIBUTE(
"This property is deprecated and will be removed in a future version of the SDK. See "
"SentryProfileOptions.startOnAppStart and SentryProfileOptions.lifecycle");

/**
* @note Profiling is not supported on watchOS or tvOS.
Expand Down
3 changes: 0 additions & 3 deletions Sources/Sentry/SentyOptionsInternal.m
Original file line number Diff line number Diff line change
Expand Up @@ -373,9 +373,6 @@ + (BOOL)validateOptions:(NSDictionary<NSString *, id> *)options
# pragma clang diagnostic ignored "-Wdeprecated-declarations"
[self setBool:options[@"enableProfiling"]
block:^(BOOL value) { sentryOptions.enableProfiling = value; }];

[self setBool:options[NSStringFromSelector(@selector(enableAppLaunchProfiling))]
block:^(BOOL value) { sentryOptions.enableAppLaunchProfiling = value; }];
# pragma clang diagnostic pop
# endif // !SDK_V9
#endif // SENTRY_TARGET_PROFILING_SUPPORTED
Expand Down
8 changes: 0 additions & 8 deletions Sources/Swift/Helper/SentryEnabledFeaturesBuilder.swift
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,6 @@ import Foundation
features.append("timeToFullDisplayTracing")
}

#if os(iOS) || os(macOS) || targetEnvironment(macCatalyst)
#if !SDK_V9
if options.enableAppLaunchProfiling {
features.append("appLaunchProfiling")
}
#endif // !SDK_V9
#endif // os(iOS) || os(macOS) || targetEnvironment(macCatalyst)

#if os(iOS) || os(tvOS)
#if canImport(UIKit) && !SENTRY_NO_UIKIT
if options.enablePreWarmedAppStartTracing {
Expand Down

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,6 @@ final class SentryEnabledFeaturesBuilderTests: XCTestCase {
options.enableTimeToFullDisplayTracing = true
options.swiftAsyncStacktraces = true

#if os(iOS) || os(macOS) || targetEnvironment(macCatalyst)
options.enableAppLaunchProfiling = true
#endif // os(iOS) || os(macOS) || targetEnvironment(macCatalyst)

#if os(iOS) || os(tvOS)
#if canImport(UIKit) && !SENTRY_NO_UIKIT
options.enablePreWarmedAppStartTracing = true
Expand All @@ -47,10 +43,6 @@ final class SentryEnabledFeaturesBuilderTests: XCTestCase {
XCTAssert(features.contains("timeToFullDisplayTracing"))
XCTAssert(features.contains("swiftAsyncStacktraces"))

#if os(iOS) || os(macOS) || targetEnvironment(macCatalyst)
XCTAssert(features.contains("appLaunchProfiling"))
#endif // os(iOS) || os(macOS) || targetEnvironment(macCatalyst)

#if os(iOS) || os(tvOS)
#if canImport(UIKit) && !SENTRY_NO_UIKIT
XCTAssert(features.contains("preWarmedAppStartTracing"))
Expand Down
11 changes: 0 additions & 11 deletions Tests/SentryTests/SentryOptionsTest.m
Original file line number Diff line number Diff line change
Expand Up @@ -1397,17 +1397,6 @@ - (void)testInitialScope
XCTAssertIdentical(initialScope, options.initialScope);
}

#if SENTRY_TARGET_PROFILING_SUPPORTED
# pragma clang diagnostic push
# pragma clang diagnostic ignored "-Wdeprecated-declarations"
- (void)testEnableAppLaunchProfilingDefaultValue
{
SentryOptions *options = [self getValidOptions:@{}];
XCTAssertFalse(options.enableAppLaunchProfiling);
}
# pragma clang diagnostic pop
#endif // SENTRY_TARGET_PROFILING_SUPPORTED

- (SentryOptions *)getValidOptions:(NSDictionary<NSString *, id> *)dict
{
NSError *error = nil;
Expand Down
Loading