fix: Remove property that had no effect

[noahsmartin]

This param did nothing because the default is to consider a library excluded. Since it does nothing, we can remove the property

#skip-changelog

Closes #6647

[codecov]

❌ 1 Tests Failed:

Tests completed	Failed	Passed	Skipped
3954	1	3953	55

View the top 1 failed test(s) by shortest run time

iOS_SwiftUI_UITests.FeedbackUITests::testWidgetDisplayInSwiftUIApp

Stack Traces | 0s run time

.../iOS-SwiftUI/iOS-SwiftUI-UITests/FeedbackUITests.swift:14 - Failed to get matching snapshots: Timed out while evaluating UI query.

To view more test analytics, go to the Test Analytics Dashboard
_{📋 Got 3 mins? Take this short survey to help us improve Test Analytics.}

[github-actions]

Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1216.22 ms	1249.80 ms	33.58 ms
Size	23.75 KiB	1022.79 KiB	999.04 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
4267263	1233.13 ms	1266.13 ms	33.00 ms
1f48bb7	1223.83 ms	1241.85 ms	18.02 ms
f2bfecd	1234.92 ms	1250.34 ms	15.42 ms
cb07a0e	1217.47 ms	1251.94 ms	34.47 ms
3ffd0e5	1228.04 ms	1253.04 ms	25.00 ms
f37e3fe	1230.24 ms	1254.51 ms	24.27 ms
fccc4e5	1237.80 ms	1264.16 ms	26.37 ms
a6f5396	1211.81 ms	1245.63 ms	33.82 ms
04ff3ec	1220.71 ms	1253.86 ms	33.15 ms
e64d3d4	1241.90 ms	1260.10 ms	18.20 ms

App size

Revision	Plain	With Sentry	Diff
4267263	23.75 KiB	988.03 KiB	964.28 KiB
1f48bb7	23.75 KiB	971.98 KiB	948.24 KiB
f2bfecd	23.75 KiB	919.68 KiB	895.93 KiB
cb07a0e	23.75 KiB	1.01 MiB	1016.13 KiB
3ffd0e5	23.75 KiB	947.55 KiB	923.80 KiB
f37e3fe	23.75 KiB	919.70 KiB	895.95 KiB
fccc4e5	23.75 KiB	974.94 KiB	951.19 KiB
a6f5396	23.75 KiB	989.12 KiB	965.38 KiB
04ff3ec	23.75 KiB	880.26 KiB	856.52 KiB
e64d3d4	23.75 KiB	855.37 KiB	831.62 KiB

Previous results on branch: removeUselessInAppExcludes

Startup times

Revision	Plain	With Sentry	Diff
acffe26	1234.77 ms	1264.96 ms	30.18 ms
3394e99	1221.17 ms	1242.04 ms	20.88 ms

App size

Revision	Plain	With Sentry	Diff
acffe26	23.75 KiB	1022.92 KiB	999.18 KiB
3394e99	23.75 KiB	1022.79 KiB	999.05 KiB

[philprime]

Instead of removing the field we should fix the usage of it internally.

This field also exists for Sentry Java:

https://docs.sentry.io/platforms/java/configuration/options/#inAppExcludes

https://github.com/getsentry/sentry-java/blob/ab8a72db41b2e5c66e60cef3102294dddba90b20/sentry/src/main/java/io/sentry/SentryOptions.java#L239-L244

https://github.com/getsentry/sentry-java/blob/main/sentry/src/main/java/io/sentry/SentryStackTraceFactory.java#L81-L101

[philprime]

See feedback above

[noahsmartin]

@philprime how would you fix it exactly? The default is for a frame that doesn't appear in inAppInclude or inAppExclude to be considered excluded, so since inAppInclude is checked first, inAppExclude does nothing

[philipphofmann]

Yes, currently inAppExclude does nothing. It's the same on Java, if I'm not mistaken.

sentry-cocoa/Sources/Swift/Core/Helper/SentryInAppLogic.swift

Lines 75 to 81 in 2b0eac0

	for inAppExclude in inAppExcludes {
	if imageNameLastPathComponent.hasPrefix(inAppExclude) {
	return false
	}
	}
	return false

This is just extra logic and confuses users. I'm OK with removing it, but we must also update the docs here https://docs.sentry.io/platforms/apple/guides/ios/configuration/options/#inAppExclude

We should also udpate the code comment here

sentry-cocoa/Sources/Swift/Core/Helper/SentryInAppLogic.swift

Lines 51 to 61 in 2b0eac0

	/**
	* Determines if the framework belongs to the app by using @c inAppIncludes and @c inAppExcludes.
	* Before checking this method lowercases the strings and uses only the @c lastPathComponent of the
	* @c imagePath.
	*
	* @param imagePath the full path of the binary image.
	*
	* @return @c YES if the framework located at the @c imagePath starts with a prefix of
	* @c inAppIncludes. @c NO if the framework located at the @c imagePath doesn't start with a prefix of
	* @c inAppIncludes or start with a prefix of @c inAppExcludes.
	*/

And also this branch still has a couple of occurrences of inAppExcludes which we should remove:

[noahsmartin]

@philipphofmann I just made a PR for the docs: getsentry/sentry-docs#15399

[philipphofmann]

Thanks, @noahsmartin

[philipphofmann]

I also created an issue #6677 and added it to the docs PR v9 milestone in Linear https://linear.app/getsentry/project/cocoa-sdk-900-19a03b661aba/overview#milestone-1389bf73-963e-490a-ac6e-3de6df5515fb, so we don't forget to merge it once V9 is out.

[github-actions]

🚨 Detected changes in high risk code 🚨

High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:

• Sources/Sentry/SentryUIViewControllerSwizzling.m