Skip to content

Conversation

@itaybre
Copy link
Contributor

@itaybre itaybre commented Jan 7, 2026

📜 Description

Skips some (non critical) jobs when a PR comes from an external user to facilitate collaboration

💡 Motivation and Context

Some steps require the use secrets, thus they fail when running from a fork.
This should let us receive PRs from users external to Sentry.

💚 How did you test it?

📝 Checklist

You have to check all boxes before merging:

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

Closes #7128

@itaybre itaybre added the ready-to-merge Use this label to trigger all PR workflows label Jan 7, 2026
@itaybre itaybre removed the ready-to-merge Use this label to trigger all PR workflows label Jan 7, 2026
@itaybre itaybre added the ready-to-merge Use this label to trigger all PR workflows label Jan 7, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2026

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1223.91 ms 1238.25 ms 14.34 ms
Size 24.15 KiB 1.03 MiB 1.01 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
35c962f 1207.61 ms 1235.90 ms 28.29 ms
650d802 1231.86 ms 1255.64 ms 23.78 ms
8ea5293 1242.70 ms 1262.25 ms 19.55 ms
e58d7bf 1219.98 ms 1242.39 ms 22.41 ms
4558de2 1225.29 ms 1258.35 ms 33.06 ms
32f2329 1224.36 ms 1257.33 ms 32.98 ms
0f410ad 1193.34 ms 1255.49 ms 62.15 ms
4be5cd8 1222.35 ms 1251.43 ms 29.07 ms
018037b 1209.31 ms 1228.33 ms 19.03 ms
5aa3ce5 1222.78 ms 1245.39 ms 22.61 ms

App size

Revision Plain With Sentry Diff
35c962f 23.75 KiB 854.77 KiB 831.02 KiB
650d802 23.74 KiB 913.13 KiB 889.39 KiB
8ea5293 23.75 KiB 852.24 KiB 828.49 KiB
e58d7bf 24.15 KiB 1.01 MiB 1014.91 KiB
4558de2 24.14 KiB 1.03 MiB 1.00 MiB
32f2329 23.75 KiB 1.01 MiB 1016.02 KiB
0f410ad 24.14 KiB 1.01 MiB 1014.82 KiB
4be5cd8 23.75 KiB 980.80 KiB 957.06 KiB
018037b 23.75 KiB 867.16 KiB 843.41 KiB
5aa3ce5 23.75 KiB 904.54 KiB 880.79 KiB

@itaybre
Copy link
Contributor Author

itaybre commented Jan 7, 2026

Aside from the XCFramework check (which also failed here), everything passed on #7125

@codecov
Copy link

codecov bot commented Jan 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.720%. Comparing base (33ade5e) to head (b9932c8).
⚠️ Report is 3 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #7124       +/-   ##
=============================================
+ Coverage   84.716%   84.720%   +0.003%     
=============================================
  Files          459       459               
  Lines        27494     27494               
  Branches     12120     12125        +5     
=============================================
+ Hits         23292     23293        +1     
- Misses        3942      4162      +220     
+ Partials       260        39      -221     

see 36 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33ade5e...b9932c8. Read the comment docs.

Copy link
Member

@philprime philprime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost LGTM

Copy link
Member

@philprime philprime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@itaybre itaybre merged commit ef26eca into main Jan 9, 2026
195 checks passed
@itaybre itaybre deleted the itay/skip_some_jobs_for_non_contributors branch January 9, 2026 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Use this label to trigger all PR workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: Skip jobs/steps that require secrets for non contributors

4 participants