-
-
Notifications
You must be signed in to change notification settings - Fork 375
chore: Skip jobs/steps that require secrets for non contributors #7124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 35c962f | 1207.61 ms | 1235.90 ms | 28.29 ms |
| 650d802 | 1231.86 ms | 1255.64 ms | 23.78 ms |
| 8ea5293 | 1242.70 ms | 1262.25 ms | 19.55 ms |
| e58d7bf | 1219.98 ms | 1242.39 ms | 22.41 ms |
| 4558de2 | 1225.29 ms | 1258.35 ms | 33.06 ms |
| 32f2329 | 1224.36 ms | 1257.33 ms | 32.98 ms |
| 0f410ad | 1193.34 ms | 1255.49 ms | 62.15 ms |
| 4be5cd8 | 1222.35 ms | 1251.43 ms | 29.07 ms |
| 018037b | 1209.31 ms | 1228.33 ms | 19.03 ms |
| 5aa3ce5 | 1222.78 ms | 1245.39 ms | 22.61 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 35c962f | 23.75 KiB | 854.77 KiB | 831.02 KiB |
| 650d802 | 23.74 KiB | 913.13 KiB | 889.39 KiB |
| 8ea5293 | 23.75 KiB | 852.24 KiB | 828.49 KiB |
| e58d7bf | 24.15 KiB | 1.01 MiB | 1014.91 KiB |
| 4558de2 | 24.14 KiB | 1.03 MiB | 1.00 MiB |
| 32f2329 | 23.75 KiB | 1.01 MiB | 1016.02 KiB |
| 0f410ad | 24.14 KiB | 1.01 MiB | 1014.82 KiB |
| 4be5cd8 | 23.75 KiB | 980.80 KiB | 957.06 KiB |
| 018037b | 23.75 KiB | 867.16 KiB | 843.41 KiB |
| 5aa3ce5 | 23.75 KiB | 904.54 KiB | 880.79 KiB |
|
Aside from the XCFramework check (which also failed here), everything passed on #7125 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7124 +/- ##
=============================================
+ Coverage 84.716% 84.720% +0.003%
=============================================
Files 459 459
Lines 27494 27494
Branches 12120 12125 +5
=============================================
+ Hits 23292 23293 +1
- Misses 3942 4162 +220
+ Partials 260 39 -221 see 36 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
philprime
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost LGTM
philprime
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
📜 Description
Skips some (non critical) jobs when a PR comes from an external user to facilitate collaboration
💡 Motivation and Context
Some steps require the use secrets, thus they fail when running from a fork.
This should let us receive PRs from users external to Sentry.
💚 How did you test it?
📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.Closes #7128