Skip to content

Conversation

@BYK
Copy link
Member

@BYK BYK commented Jan 10, 2026

Summary

This is a minimal migration that preserves all existing workflow structure.

Changes

  • Updated getsentry/action-prepare-release@v1 to getsentry/craft@v2 (SHA pinned)
  • Added changelog-preview.yml workflow with proper permissions block

What's NOT changed

  • All XCFramework build jobs preserved
  • All validation jobs preserved (SPM, duplication tests, app metrics)
  • All triggers preserved (push, pull_request, workflow_dispatch)
  • Concurrency settings preserved

Why this PR?

The previous PR #7150 was too aggressive and removed essential build infrastructure. This minimal approach only updates the action reference while preserving all existing functionality.

Replaces #7150

This is a minimal migration that only updates the action reference.
All existing build steps and workflow structure are preserved.

Changes:
- Updated action-prepare-release@v1 to getsentry/craft@v2 (SHA pinned)
- Added changelog-preview.yml workflow with permissions block
@github-actions
Copy link
Contributor

github-actions bot commented Jan 10, 2026

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


New Features ✨

  • Add isiOSAppOnVisionOS, isiOSAppOnMac, isMacCatalystApp to device context by philprime in #6939

Bug Fixes 🐛

  • (logs) Use sendDefaultPii and span_id for attributes by philprime in #7055
  • Fix incorrect variable assignment for 'sampled' key by xjshi in #7120
  • Mark dark theme deprecated by noahsmartin in #7114
  • Update raw_description in runtime context for Mac Catalyst App by philprime in #7082
  • Use correct parsing for stackframes by noahsmartin in #6908
  • Transport correctly handling 4xx and 5xx by dfed in #6618

Build / dependencies / internal 🔧

Deps

  • Bump ruby/setup-ruby from 1.276.0 to 1.279.0 by dependabot in #7117
  • Bump mikepenz/action-junit-report from 6.0.1 to 6.1.0 by dependabot in #7116
  • Update swiftlint version by github-actions in #7109
  • Bump ruby/setup-ruby from 1.275.0 to 1.276.0 by dependabot in #7103
  • Bump codecov/test-results-action from 1.1.1 to 1.2.1 by itaybre in #7087
  • Bump ruby/setup-ruby from 1.270.0 to 1.275.0 by itaybre in #7088
  • Bump peter-evans/create-pull-request from 7.0.11 to 8.0.0 by dependabot in #7084
  • Bump actions/download-artifact from 6 to 7 by dependabot in #7048
  • Bump aws-sdk-s3 from 1.205.0 to 1.208.0 by dependabot in #7074
  • Bump ruby/setup-ruby from 1.269.0 to 1.270.0 by dependabot in #7049
  • Update clang-format version by github-actions in #7056
  • Bump actions/cache from 4 to 5 by dependabot in #7052
  • Bump actions/upload-artifact from 5 to 6 by dependabot in #7050
  • Bump codecov/codecov-action from 5.5.1 to 5.5.2 by dependabot in #7051

Other

  • (release) Switch from action-prepare-release to Craft (minimal) by BYK in #7153
  • Fix typos in comments in multiple files v2 by philipphofmann in #7139
  • Run visionOS tests on Cirrus Runners + Boot simulator by itaybre in #7147
  • Skip jobs/steps that require secrets for non contributors by itaybre in #7124
  • Add attributable protocol for typed attribute values by philprime in #7077
  • Allow alpha releases on RNSentry.podspec for Cross Platform Test by itaybre in #7130
  • Remove swift5.9 checks by itaybre in #7098
  • Remove duplicate file in project by itaybre in #7093
  • Convert SentryMetricKitIntegration to Swift by noahsmartin in #7076
  • Removes HybridSDK subspec by itaybre in #7019
  • Move testRemoveImageFromTail to flaky plan by itaybre in #7041
  • Use at least xcode 16 for all jobs by itaybre in #7012
  • Cleanup file filter for required files modified by itaybre in #7031
  • Remove assembly workflow files from UI test filter by itaybre in #7030
  • Bumps macOS-14 runner to macOS-15 by itaybre in #7029
  • Ensure required simulators are loaded for all platforms by itaybre in #7022

Other

  • test: Add Options Documentation Sync Tests by philipphofmann in #7075

🤖 This preview updates automatically when you update the PR.

@github-actions
Copy link
Contributor

🚨 Detected changes in high risk code 🚨

High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:

  • .github/workflows/changes-in-high-risk-code.yml

@codecov
Copy link

codecov bot commented Jan 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.803%. Comparing base (d29a425) to head (8e34053).
⚠️ Report is 6 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #7153       +/-   ##
=============================================
+ Coverage   84.752%   84.803%   +0.050%     
=============================================
  Files          461       461               
  Lines        27814     27815        +1     
  Branches     12318     12327        +9     
=============================================
+ Hits         23573     23588       +15     
+ Misses        4196      3968      -228     
- Partials        45       259      +214     

see 37 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d29a425...8e34053. Read the comment docs.

Copy link
Member

@philprime philprime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philprime philprime enabled auto-merge (squash) January 12, 2026 13:21
@philprime philprime added the ready-to-merge Use this label to trigger all PR workflows label Jan 12, 2026
@github-actions
Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1207.60 ms 1237.02 ms 29.42 ms
Size 24.14 KiB 1.04 MiB 1.02 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
83bf9af 1213.30 ms 1234.18 ms 20.89 ms
013fd4d 1216.02 ms 1242.16 ms 26.14 ms
9f7ef2b 1213.53 ms 1250.23 ms 36.70 ms
d29a425 1209.96 ms 1239.00 ms 29.04 ms
2f4ddaa 1227.26 ms 1260.04 ms 32.78 ms
adeec82 1220.43 ms 1254.94 ms 34.51 ms
3bf0d3f 1202.12 ms 1237.23 ms 35.11 ms

App size

Revision Plain With Sentry Diff
83bf9af 24.14 KiB 1.04 MiB 1.02 MiB
013fd4d 24.14 KiB 1.04 MiB 1.02 MiB
9f7ef2b 24.14 KiB 1.04 MiB 1.02 MiB
d29a425 24.14 KiB 1.04 MiB 1.02 MiB
2f4ddaa 24.14 KiB 1.04 MiB 1.02 MiB
adeec82 24.14 KiB 1.04 MiB 1.02 MiB
3bf0d3f 24.14 KiB 1.04 MiB 1.02 MiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Use this label to trigger all PR workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants