-
-
Notifications
You must be signed in to change notification settings - Fork 375
ci(release): Switch from action-prepare-release to Craft (minimal) #7153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is a minimal migration that only updates the action reference. All existing build steps and workflow structure are preserved. Changes: - Updated action-prepare-release@v1 to getsentry/craft@v2 (SHA pinned) - Added changelog-preview.yml workflow with permissions block
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛
Build / dependencies / internal 🔧Deps
Other
Other
🤖 This preview updates automatically when you update the PR. |
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7153 +/- ##
=============================================
+ Coverage 84.752% 84.803% +0.050%
=============================================
Files 461 461
Lines 27814 27815 +1
Branches 12318 12327 +9
=============================================
+ Hits 23573 23588 +15
+ Misses 4196 3968 -228
- Partials 45 259 +214 see 37 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
philprime
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 83bf9af | 1213.30 ms | 1234.18 ms | 20.89 ms |
| 013fd4d | 1216.02 ms | 1242.16 ms | 26.14 ms |
| 9f7ef2b | 1213.53 ms | 1250.23 ms | 36.70 ms |
| d29a425 | 1209.96 ms | 1239.00 ms | 29.04 ms |
| 2f4ddaa | 1227.26 ms | 1260.04 ms | 32.78 ms |
| adeec82 | 1220.43 ms | 1254.94 ms | 34.51 ms |
| 3bf0d3f | 1202.12 ms | 1237.23 ms | 35.11 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 83bf9af | 24.14 KiB | 1.04 MiB | 1.02 MiB |
| 013fd4d | 24.14 KiB | 1.04 MiB | 1.02 MiB |
| 9f7ef2b | 24.14 KiB | 1.04 MiB | 1.02 MiB |
| d29a425 | 24.14 KiB | 1.04 MiB | 1.02 MiB |
| 2f4ddaa | 24.14 KiB | 1.04 MiB | 1.02 MiB |
| adeec82 | 24.14 KiB | 1.04 MiB | 1.02 MiB |
| 3bf0d3f | 24.14 KiB | 1.04 MiB | 1.02 MiB |
Summary
This is a minimal migration that preserves all existing workflow structure.
Changes
getsentry/action-prepare-release@v1togetsentry/craft@v2(SHA pinned)changelog-preview.ymlworkflow with proper permissions blockWhat's NOT changed
Why this PR?
The previous PR #7150 was too aggressive and removed essential build infrastructure. This minimal approach only updates the action reference while preserving all existing functionality.
Replaces #7150