ref: Renames SentrySpan class to SentrySpanInternal
#7172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Metrics
Other
Bug Fixes 🐛
Build / dependencies / internal 🔧Deps
Other
Other
🤖 This preview updates automatically when you update the PR. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7172 +/- ##
=============================================
+ Coverage 84.795% 84.938% +0.143%
=============================================
Files 461 465 +4
Lines 27860 28039 +179
Branches 12324 12392 +68
=============================================
+ Hits 23624 23816 +192
+ Misses 4195 4178 -17
- Partials 41 45 +4
... and 24 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 50e7b3e | 1221.54 ms | 1250.81 ms | 29.27 ms |
| 3bf0d3f | 1202.12 ms | 1237.23 ms | 35.11 ms |
| 2f28bda | 1221.21 ms | 1255.09 ms | 33.88 ms |
| dbfeb41 | 1215.17 ms | 1237.41 ms | 22.23 ms |
| d29a425 | 1209.96 ms | 1239.00 ms | 29.04 ms |
| 2f4ddaa | 1227.26 ms | 1260.04 ms | 32.78 ms |
| 1d0feed | 1213.31 ms | 1247.44 ms | 34.14 ms |
| adeec82 | 1220.43 ms | 1254.94 ms | 34.51 ms |
| 9f7ef2b | 1213.53 ms | 1250.23 ms | 36.70 ms |
| 2e5230b | 1207.41 ms | 1240.41 ms | 33.00 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 50e7b3e | 24.14 KiB | 1.04 MiB | 1.02 MiB |
| 3bf0d3f | 24.14 KiB | 1.04 MiB | 1.02 MiB |
| 2f28bda | 24.14 KiB | 1.05 MiB | 1.03 MiB |
| dbfeb41 | 24.14 KiB | 1.04 MiB | 1.02 MiB |
| d29a425 | 24.14 KiB | 1.04 MiB | 1.02 MiB |
| 2f4ddaa | 24.14 KiB | 1.04 MiB | 1.02 MiB |
| 1d0feed | 24.14 KiB | 1.05 MiB | 1.03 MiB |
| adeec82 | 24.14 KiB | 1.04 MiB | 1.02 MiB |
| 9f7ef2b | 24.14 KiB | 1.04 MiB | 1.02 MiB |
| 2e5230b | 24.14 KiB | 1.04 MiB | 1.02 MiB |
itaybre
requested review from
noahsmartin,
philipphofmann and
philprime
as code owners
7 tasks
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
philprime
approved these changes
Jan 15, 2026
Member
philprime
left a comment
philprime
left a comment
There was a problem hiding this comment.
LGTM, but might we worth to ask one of our coding agents to verify we caught all use cases of SentrySpan which need to be renamed
Contributor
Author
|
@sentry review |
Contributor
Author
Should be fine since if I missed any case, it shouldn't compile |
Member
philipphofmann
left a comment
philipphofmann
left a comment
There was a problem hiding this comment.
There are several replacements of id<SentrySpan> with SentrySpanInternal. I don't think these should be required.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Contributor
Author
There is no reason to use |
7 tasks
philipphofmann
approved these changes
Jan 16, 2026
Member
philipphofmann
left a comment
philipphofmann
left a comment
There was a problem hiding this comment.
Thanks for fixing this @itaybre 💯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Renames the class
SentrySpantoSentrySpanInternal, keepingSentrySpanonly to the protocol.Only the protocol is a public API, so no breaking changes were made
💡 Motivation and Context
We have 2 types with identical names, one a protocol and another a class.
While converting the SentryCrashIntegration to Swift, I ran into issues with them having the same name in ObjC.
💚 How did you test it?
📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.Closes #7176