-
-
Notifications
You must be signed in to change notification settings - Fork 376
chore: Update iOS test destination OS version to 18.5 in fast-pr-checks workflow #7168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛
Build / dependencies / internal 🔧Deps
Other
Other
🤖 This preview updates automatically when you update the PR. |
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
❌ 2 Tests Failed:
View the top 1 failed test(s) by shortest run time
View the full list of 1 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 79e2bb8 | 1216.37 ms | 1242.42 ms | 26.05 ms |
| 9f7ef2b | 1213.53 ms | 1250.23 ms | 36.70 ms |
| 2e5230b | 1207.41 ms | 1240.41 ms | 33.00 ms |
| 50e7b3e | 1221.54 ms | 1250.81 ms | 29.27 ms |
| d29a425 | 1209.96 ms | 1239.00 ms | 29.04 ms |
| 2f4ddaa | 1227.26 ms | 1260.04 ms | 32.78 ms |
| 83bf9af | 1213.30 ms | 1234.18 ms | 20.89 ms |
| 3bf0d3f | 1202.12 ms | 1237.23 ms | 35.11 ms |
| dbfeb41 | 1215.17 ms | 1237.41 ms | 22.23 ms |
| f84c826 | 1216.38 ms | 1241.98 ms | 25.60 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 79e2bb8 | 24.14 KiB | 1.04 MiB | 1.02 MiB |
| 9f7ef2b | 24.14 KiB | 1.04 MiB | 1.02 MiB |
| 2e5230b | 24.14 KiB | 1.04 MiB | 1.02 MiB |
| 50e7b3e | 24.14 KiB | 1.04 MiB | 1.02 MiB |
| d29a425 | 24.14 KiB | 1.04 MiB | 1.02 MiB |
| 2f4ddaa | 24.14 KiB | 1.04 MiB | 1.02 MiB |
| 83bf9af | 24.14 KiB | 1.04 MiB | 1.02 MiB |
| 3bf0d3f | 24.14 KiB | 1.04 MiB | 1.02 MiB |
| dbfeb41 | 24.14 KiB | 1.04 MiB | 1.02 MiB |
| f84c826 | 24.14 KiB | 1.04 MiB | 1.02 MiB |
📜 Description
GH removed iOS 18.4 from the runtime, and after fixing this on #7167, looks like we forgot updating this place.
Failed PR: https://github.com/getsentry/sentry-cocoa/actions/runs/20967394439/job/60261448330?pr=7106
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.Closes #7169