Skip to content

Conversation

@itaybre
Copy link
Contributor

@itaybre itaybre commented Jan 13, 2026

📜 Description

GH removed iOS 18.4 from the runtime, and after fixing this on #7167, looks like we forgot updating this place.
Failed PR: https://github.com/getsentry/sentry-cocoa/actions/runs/20967394439/job/60261448330?pr=7106

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

You have to check all boxes before merging:

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

Closes #7169

@github-actions
Copy link
Contributor

github-actions bot commented Jan 13, 2026

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


New Features ✨

  • Add isiOSAppOnVisionOS, isiOSAppOnMac, isMacCatalystApp to device context by philprime in #6939

Bug Fixes 🐛

  • (logs) Use sendDefaultPii and span_id for attributes by philprime in #7055
  • Fix incorrect variable assignment for 'sampled' key by xjshi in #7120
  • Mark dark theme deprecated by noahsmartin in #7114
  • Update raw_description in runtime context for Mac Catalyst App by philprime in #7082
  • Use correct parsing for stackframes by noahsmartin in #6908
  • Transport correctly handling 4xx and 5xx by dfed in #6618

Build / dependencies / internal 🔧

Deps

  • Bump getsentry/craft from 2.18.1 to 2.18.3 by dependabot in #7161
  • Bump getsentry/craft/.github/workflows/changelog-preview.yml from 2.18.1 to 2.18.3 by dependabot in #7159
  • Bump ruby/setup-ruby from 1.276.0 to 1.279.0 by dependabot in #7117
  • Bump mikepenz/action-junit-report from 6.0.1 to 6.1.0 by dependabot in #7116
  • Update swiftlint version by github-actions in #7109
  • Bump ruby/setup-ruby from 1.275.0 to 1.276.0 by dependabot in #7103
  • Bump codecov/test-results-action from 1.1.1 to 1.2.1 by itaybre in #7087
  • Bump ruby/setup-ruby from 1.270.0 to 1.275.0 by itaybre in #7088
  • Bump peter-evans/create-pull-request from 7.0.11 to 8.0.0 by dependabot in #7084
  • Bump actions/download-artifact from 6 to 7 by dependabot in #7048
  • Bump aws-sdk-s3 from 1.205.0 to 1.208.0 by dependabot in #7074
  • Bump ruby/setup-ruby from 1.269.0 to 1.270.0 by dependabot in #7049
  • Update clang-format version by github-actions in #7056
  • Bump actions/cache from 4 to 5 by dependabot in #7052
  • Bump actions/upload-artifact from 5 to 6 by dependabot in #7050
  • Bump codecov/codecov-action from 5.5.1 to 5.5.2 by dependabot in #7051

Other

  • (dx) Add structured Makefile with usage description by philprime in #7129
  • (release) Switch from action-prepare-release to Craft (minimal) by BYK in #7153
  • Update iOS test destination OS version to 18.5 in fast-pr-checks workflow by itaybre in #7168
  • Fix typos in comments in multiple files v2 by philipphofmann in #7139
  • Run visionOS tests on Cirrus Runners + Boot simulator by itaybre in #7147
  • Skip jobs/steps that require secrets for non contributors by itaybre in #7124
  • Add attributable protocol for typed attribute values by philprime in #7077
  • Allow alpha releases on RNSentry.podspec for Cross Platform Test by itaybre in #7130
  • Remove swift5.9 checks by itaybre in #7098
  • Remove duplicate file in project by itaybre in #7093
  • Convert SentryMetricKitIntegration to Swift by noahsmartin in #7076
  • Removes HybridSDK subspec by itaybre in #7019
  • Move testRemoveImageFromTail to flaky plan by itaybre in #7041
  • Use at least xcode 16 for all jobs by itaybre in #7012
  • Cleanup file filter for required files modified by itaybre in #7031
  • Remove assembly workflow files from UI test filter by itaybre in #7030
  • Bumps macOS-14 runner to macOS-15 by itaybre in #7029
  • Ensure required simulators are loaded for all platforms by itaybre in #7022

Other

  • test: Add Options Documentation Sync Tests by philipphofmann in #7075

🤖 This preview updates automatically when you update the PR.

@github-actions
Copy link
Contributor

🚨 Detected changes in high risk code 🚨

High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:

  • .github/file-filters.yml

@itaybre itaybre added the ready-to-merge Use this label to trigger all PR workflows label Jan 13, 2026
@itaybre itaybre marked this pull request as ready for review January 13, 2026 18:31
@codecov
Copy link

codecov bot commented Jan 13, 2026

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
4216 2 4214 24
View the top 1 failed test(s) by shortest run time
SentryTests.PrivateSentrySDKOnlyTests::testProfilingStartAndCollect
Stack Traces | 0s run time
.../Tests/SentryTests/PrivateSentrySDKOnlyTests.swift:271 - XCTAssertGreaterThan failed: ("0") is not greater than ("0")
View the full list of 1 ❄️ flaky test(s)
SentryTests.SentryOnDemandReplayTests::testAddFrameIsThreadSafe

Flake rate in main: 100.00% (Passed 0 times, Failed 38 times)

Stack Traces | 0s run time
.../Integrations/SessionReplay/SentryOnDemandReplayTests.swift:139 - Asynchronous wait failed: Exceeded timeout of 10 seconds, with unfulfilled expectations: "AddFrameIsThreadSafe".

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@itaybre itaybre enabled auto-merge (squash) January 13, 2026 18:46
@github-actions
Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1212.52 ms 1251.96 ms 39.44 ms
Size 24.14 KiB 1.04 MiB 1.02 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
79e2bb8 1216.37 ms 1242.42 ms 26.05 ms
9f7ef2b 1213.53 ms 1250.23 ms 36.70 ms
2e5230b 1207.41 ms 1240.41 ms 33.00 ms
50e7b3e 1221.54 ms 1250.81 ms 29.27 ms
d29a425 1209.96 ms 1239.00 ms 29.04 ms
2f4ddaa 1227.26 ms 1260.04 ms 32.78 ms
83bf9af 1213.30 ms 1234.18 ms 20.89 ms
3bf0d3f 1202.12 ms 1237.23 ms 35.11 ms
dbfeb41 1215.17 ms 1237.41 ms 22.23 ms
f84c826 1216.38 ms 1241.98 ms 25.60 ms

App size

Revision Plain With Sentry Diff
79e2bb8 24.14 KiB 1.04 MiB 1.02 MiB
9f7ef2b 24.14 KiB 1.04 MiB 1.02 MiB
2e5230b 24.14 KiB 1.04 MiB 1.02 MiB
50e7b3e 24.14 KiB 1.04 MiB 1.02 MiB
d29a425 24.14 KiB 1.04 MiB 1.02 MiB
2f4ddaa 24.14 KiB 1.04 MiB 1.02 MiB
83bf9af 24.14 KiB 1.04 MiB 1.02 MiB
3bf0d3f 24.14 KiB 1.04 MiB 1.02 MiB
dbfeb41 24.14 KiB 1.04 MiB 1.02 MiB
f84c826 24.14 KiB 1.04 MiB 1.02 MiB

@itaybre itaybre merged commit bb418da into main Jan 13, 2026
256 of 271 checks passed
@itaybre itaybre deleted the itay/change_os_used_for_fast_pr_check branch January 13, 2026 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Use this label to trigger all PR workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: Update iOS test destination OS version to 18.5 in fast-pr-checks workflow

3 participants