Conversation
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Bug Fixes 🐛
Documentation 📚
Internal Changes 🔧
Other
🤖 This preview updates automatically when you update the PR. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7405 +/- ##
========================================
Coverage ? 85.025%
========================================
Files ? 482
Lines ? 28628
Branches ? 12448
========================================
Hits ? 24341
Misses ? 4239
Partials ? 48
Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 47c9f79 | 1216.57 ms | 1240.94 ms | 24.37 ms |
| d8db577 | 1206.83 ms | 1244.39 ms | 37.56 ms |
| 59981b9 | 1207.25 ms | 1240.71 ms | 33.46 ms |
| e1e5f3b | 1220.60 ms | 1241.63 ms | 21.04 ms |
| 0e4a9dc | 1222.92 ms | 1255.78 ms | 32.86 ms |
| db9e223 | 1193.69 ms | 1213.56 ms | 19.87 ms |
| e701dc8 | 1215.89 ms | 1254.06 ms | 38.17 ms |
| b984142 | 1219.17 ms | 1250.17 ms | 31.00 ms |
| 3bff9ff | 1217.72 ms | 1246.43 ms | 28.71 ms |
| 2c4362a | 1231.50 ms | 1255.95 ms | 24.45 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 47c9f79 | 24.14 KiB | 1.09 MiB | 1.06 MiB |
| d8db577 | 24.14 KiB | 1.06 MiB | 1.04 MiB |
| 59981b9 | 24.14 KiB | 1.09 MiB | 1.06 MiB |
| e1e5f3b | 24.14 KiB | 1.06 MiB | 1.04 MiB |
| 0e4a9dc | 24.14 KiB | 1.11 MiB | 1.09 MiB |
| db9e223 | 24.14 KiB | 1.06 MiB | 1.03 MiB |
| e701dc8 | 24.14 KiB | 1.06 MiB | 1.04 MiB |
| b984142 | 24.14 KiB | 1.11 MiB | 1.09 MiB |
| 3bff9ff | 24.14 KiB | 1.11 MiB | 1.09 MiB |
| 2c4362a | 24.14 KiB | 1.07 MiB | 1.04 MiB |
Previous results on branch: itay/swift-sentry-sample
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| edb00a9 | 1225.69 ms | 1259.46 ms | 33.77 ms |
| 559d353 | 1210.88 ms | 1248.72 ms | 37.85 ms |
| 71b09bb | 1217.77 ms | 1242.62 ms | 24.85 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| edb00a9 | 24.14 KiB | 1.10 MiB | 1.08 MiB |
| 559d353 | 24.14 KiB | 1.10 MiB | 1.08 MiB |
| 71b09bb | 24.14 KiB | 1.10 MiB | 1.08 MiB |
philprime
left a comment
There was a problem hiding this comment.
To be honest I don't see the value of this conversion, as it changes one file from Objective-C++ to Swift, but introduces 4 additional ones. Is this just an intermediate addition?
This one in particular is not relevant, I was testing compatibility with ObjC++ and Swift. |
philprime
left a comment
There was a problem hiding this comment.
I'll leave the decision to you.
Remove orphaned PBXBuildFile and PBXFileReference entries for SentryPredicateDescriptor.m and .h. These files were deleted when SentryPredicateDescriptor was migrated to Swift; the project references caused potential build issues.
|
@sentry review |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
📜 Description
Converts
SentrySampleto Swift, mostly done by claude💡 Motivation and Context
Less ObjC 🙌
💚 How did you test it?
📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.Closes #7429