ref: Convert SentrySample to Swift
#7405
+125
−48
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| #if defined(DEBUG) | ||
|
|
||
| # import "SentryProfileLoggerHelper.h" | ||
|
Check failure on line 3 in Sources/Sentry/Profiling/SentryProfileDebugLoggerHelper.m
|
||
| # import "SentrySwift.h" | ||
|
|
||
| @implementation SentryProfileLoggerHelper | ||
|
|
||
| + (uint64_t)getAbsoluteTimeStampFromSample:(SentrySample *)sample | ||
| { | ||
| return sample.absoluteTimestamp; | ||
| } | ||
|
|
||
| @end | ||
|
|
||
| #endif | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| #import "SentryProfilerSampleCreation.h" | ||
| #if SENTRY_TARGET_PROFILING_SUPPORTED | ||
| # import "SentryInternalDefines.h" | ||
| # import "SentrySwift.h" | ||
|
|
||
| SentrySample * | ||
| sentry_profilerSampleWithStack(NSArray<NSNumber *> *stack, uint64_t absoluteTimestamp, | ||
| NSTimeInterval absoluteNSDateInterval, uint64_t threadID, SentryProfilerMutableState *state) | ||
| { | ||
| SentrySample *sample = [[SentrySample alloc] init]; | ||
| sample.absoluteTimestamp = absoluteTimestamp; | ||
| sample.absoluteNSDateInterval = absoluteNSDateInterval; | ||
| sample.threadID = threadID; | ||
|
|
||
| NSString *stackKey = [stack componentsJoinedByString:@"|"]; | ||
| NSNumber *_Nullable stackIndex = state.stackIndexLookup[stackKey]; | ||
| if (stackIndex) { | ||
| sample.stackIndex = SENTRY_UNWRAP_NULLABLE(NSNumber, stackIndex); | ||
| } else { | ||
| NSNumber *nextStackIndex = @(state.stacks.count); | ||
| sample.stackIndex = nextStackIndex; | ||
| state.stackIndexLookup[stackKey] = nextStackIndex; | ||
| [state.stacks addObject:stack]; | ||
| } | ||
|
|
||
| return sample; | ||
| } | ||
|
|
||
| #endif // SENTRY_TARGET_PROFILING_SUPPORTED |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| #import <Foundation/Foundation.h> | ||
|
|
||
| #if defined(DEBUG) | ||
|
|
||
| @class SentrySample; | ||
|
|
||
| NS_ASSUME_NONNULL_BEGIN | ||
|
|
||
| @interface SentryProfileLoggerHelper : NSObject | ||
|
|
||
| + (uint64_t)getAbsoluteTimeStampFromSample:(SentrySample *)sample; | ||
|
|
||
| @end | ||
|
|
||
| NS_ASSUME_NONNULL_END | ||
|
|
||
| #endif defined(DEBUG) | ||
cursor[bot] marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| #import "SentryProfilingConditionals.h" | ||
|
|
||
| #if SENTRY_TARGET_PROFILING_SUPPORTED | ||
|
|
||
| # import "SentryProfilerState.h" | ||
| # import <Foundation/Foundation.h> | ||
|
|
||
| NS_ASSUME_NONNULL_BEGIN | ||
|
|
||
| /** | ||
| * Creates a profiler sample from a stack of frame indices and appends the stack to state if new. | ||
| * Used so that SentrySample (Swift) is only referenced from Objective-C, not from Objective-C++. | ||
| */ | ||
| # if defined(__cplusplus) | ||
| extern "C" { | ||
| # endif | ||
| SentrySample *sentry_profilerSampleWithStack(NSArray<NSNumber *> *stack, uint64_t absoluteTimestamp, | ||
| NSTimeInterval absoluteNSDateInterval, uint64_t threadID, SentryProfilerMutableState *state); | ||
| # if defined(__cplusplus) | ||
| } | ||
| # endif | ||
|
|
||
| NS_ASSUME_NONNULL_END | ||
|
|
||
| #endif // SENTRY_TARGET_PROFILING_SUPPORTED |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| import Foundation | ||
|
|
||
| // swiftlint:disable missing_docs | ||
|
|
||
| /// A storage class to hold the data associated with a single profiler sample. | ||
| @objcMembers | ||
| @_spi(Private) public final class SentrySample: NSObject { | ||
| public var absoluteTimestamp: UInt64 = 0 | ||
| public var absoluteNSDateInterval: TimeInterval = 0 | ||
| public var stackIndex: NSNumber = NSNumber(value: 0) | ||
| public var threadID: UInt64 = 0 | ||
| public var queueAddress: String? | ||
| } | ||
|
|
||
| // swiftlint:enable missing_docs |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.