test: Fix flaky HangTracker deallocated test#7639
Merged
noahsmartin merged 1 commit intomainfrom Mar 9, 2026
Merged
Conversation
noahsmartin
requested review from
itaybre,
philipphofmann and
philprime
as code owners
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛
Internal Changes 🔧Deps
Samples
Other
🤖 This preview updates automatically when you update the PR. |
noahsmartin
force-pushed
the
fixHangTrackerTestFlake
branch
from
0ff4681 to
19fa97c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7639 +/- ##
=============================================
+ Coverage 85.325% 85.356% +0.031%
=============================================
Files 483 483
Lines 28785 28785
Branches 12506 12518 +12
=============================================
+ Hits 24561 24570 +9
+ Misses 4177 4169 -8
+ Partials 47 46 -1
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Sentry Build Distribution
|
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 98a16ef | 1227.45 ms | 1258.19 ms | 30.74 ms |
| 70fb69e | 1230.45 ms | 1257.00 ms | 26.55 ms |
| 9a34176 | 1227.24 ms | 1266.22 ms | 38.98 ms |
| 59981b9 | 1207.25 ms | 1240.71 ms | 33.46 ms |
| 8ef5e41 | 1214.14 ms | 1248.52 ms | 34.38 ms |
| 26ae2f8 | 1221.61 ms | 1250.76 ms | 29.14 ms |
| 83bf9af | 1213.30 ms | 1234.18 ms | 20.89 ms |
| 2d1826b | 1216.96 ms | 1254.05 ms | 37.09 ms |
| b66e455 | 1211.30 ms | 1241.39 ms | 30.08 ms |
| 70fb69e | 1215.23 ms | 1241.84 ms | 26.61 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 98a16ef | 24.14 KiB | 1.09 MiB | 1.07 MiB |
| 70fb69e | 24.14 KiB | 1.11 MiB | 1.09 MiB |
| 9a34176 | 24.14 KiB | 1.10 MiB | 1.07 MiB |
| 59981b9 | 24.14 KiB | 1.09 MiB | 1.06 MiB |
| 8ef5e41 | 24.14 KiB | 1.10 MiB | 1.08 MiB |
| 26ae2f8 | 24.14 KiB | 1.11 MiB | 1.09 MiB |
| 83bf9af | 24.14 KiB | 1.04 MiB | 1.02 MiB |
| 2d1826b | 24.14 KiB | 1.12 MiB | 1.09 MiB |
| b66e455 | 24.14 KiB | 1.11 MiB | 1.09 MiB |
| 70fb69e | 24.14 KiB | 1.11 MiB | 1.09 MiB |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test would flake if the hang tracker's background thread hadn't finished running (a race condition). This fixes it and adds a comment to help explain why accessing
mainThreadStateis safe even when the deinit isn't documented to only be called on the main threadCloses #7640