Skip to content

test: Fix flaky HangTracker deallocated test #7639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
noahsmartin merged 1 commit into from
Mar 9, 2026
Merged

test: Fix flaky HangTracker deallocated test #7639

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Sources/Swift/HangTracker.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,9 @@ final class DefaultHangTracker<T: RunLoopObserver> {
mainQueueState = .init()
}

// It's safe to access mainQueueState here regardless of the thread
// because this is the only reference to `self` while
// it is being deallocated.
deinit {
guard let observer = mainQueueState.observer else {
return
Expand Down
8 changes: 8 additions & 0 deletions Tests/SentryTests/Integrations/ANR/HangTrackerTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,14 @@ final class HangTrackerTests: XCTestCase {

sut = nil

// Allow the hang tracker's background thread to finish since it holds
// a strong reference while it is running
let expectation = XCTestExpectation()
queue.async {
expectation.fulfill()
}
wait(for: [expectation])

XCTAssertNil(weakSut, "Expected observer to be deallocated")
}

Expand Down
Loading