Skip to content

Conversation

@a-hariti
Copy link
Collaborator

@a-hariti a-hariti commented Feb 6, 2025

The current behavior of the sidebar is is jarring when dealing with items below the fold

this PR makes it smarter and behave as expected

closes #10978

@vercel
Copy link

vercel bot commented Feb 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 6:44pm
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 6:44pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Feb 7, 2025 6:44pm

@codecov
Copy link

codecov bot commented Feb 6, 2025

Bundle Report

Changes will increase total bundle size by 679 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-client-array-push 9.39MB 679 bytes (0.01%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.64MB -0.0%
../instrumentation.js -3 bytes 968.3kB -0.0%
9523.js -3 bytes 944.51kB -0.0%
2065.js 9 bytes 81.45kB 0.01%

Files in 2065.js:

  • ./src/components/focus-active-link.tsx → Total Size: 485 bytes

  • ./src/components/focus-active-link.tsx → Total Size: 2.47kB

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 865.95kB -0.0%
static/chunks/7801-*.js -3 bytes 391.02kB -0.0%
static/chunks/818-*.js 685 bytes 42.19kB 1.65%
server/middleware-*.js 5.55kB 6.55kB 555.3% ⚠️
server/middleware-*.js -5.55kB 1.0kB -84.74%
static/xkUQDgehdAA1IfSJCQqG9/_buildManifest.js (New) 578 bytes 578 bytes 100.0% 🚀
static/xkUQDgehdAA1IfSJCQqG9/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/hFfg1zwdK2ogru9eMw4bM/_buildManifest.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
static/hFfg1zwdK2ogru9eMw4bM/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

Files in static/chunks/818-*.js:

  • ./src/components/focus-active-link.tsx → Total Size: 2.64kB

@a-hariti a-hariti requested review from chargome and mydea February 6, 2025 19:21
@a-hariti a-hariti changed the title fix: nicer sidebar scroll position behavior fix: smarter sidebar scrolling behavior Feb 6, 2025
Copy link
Member

@chargome chargome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this, works great! Left some feedback comments

Copy link
Member

@chargome chargome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@chargome chargome marked this pull request as draft February 10, 2025 16:56
@a-hariti a-hariti marked this pull request as ready for review February 10, 2025 20:47
@a-hariti a-hariti merged commit 2ee9283 into master Feb 10, 2025
13 checks passed
@a-hariti a-hariti deleted the persistant-sidebar branch February 10, 2025 20:47
@github-actions github-actions bot locked and limited conversation to collaborators Feb 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Auto-scroll to active element in nav sidebar

3 participants