Skip to content

chore(apple): add SentrySDK.startProfiler to configure #13014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
philprime wants to merge 2 commits into from
Closed

chore(apple): add SentrySDK.startProfiler to configure #13014

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2917df6
chore(apple): add SentrySDK.startProfiler to configure
philprime Mar 17, 2025
c43335a
added conditional display of lines
philprime Mar 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion docs/platforms/apple/common/index.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ To capture all errors, initialize the SDK as soon as possible, such as in your `

<PlatformSection notSupported={["apple.tvos", "apple.watchos", "apple.visionos"]}>

```swift {tabTitle:Swift} {"onboardingOptions": {"performance": "13-16", "profiling": "18-28"}}
```swift {tabTitle:Swift} {"onboardingOptions": {"performance": "13-16", "profiling": "18-28,32-38"}}
import Sentry

func application(_ application: UIApplication,
Expand Down Expand Up @@ -119,6 +119,13 @@ func application(_ application: UIApplication,

return true
}

// Start continuous profiling when the app becomes active again.
//
// This is optional, and you can start and stop the profiler as needed.
func applicationDidBecomeActive(_ application: UIApplication) {
SentrySDK.startProfiler()
}
Comment on lines +126 to +128
Copy link
Member

@philipphofmann philipphofmann Mar 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this doesn't add too much noise. We already mention SentrySDK.startProfiler() above and tell the user that they have to manually start and stop the profiler.

Copy link
Member Author

@philprime philprime Mar 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that this is duplicate text. I am questioning the value of displaying the SentrySDK.startProfile() in the didFinishLaunch method alltogether.

```

```objc {tabTitle:Objective-C} {"onboardingOptions": {"performance": "12-15", "profiling": "17-27"}}
Expand Down