Skip to content

docs(sdk): Clarify HTTP response codes considered successful #13256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markushi merged 2 commits into from
Apr 23, 2025
Merged

docs(sdk): Clarify HTTP response codes considered successful #13256

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b9ad701
chore(sdk): Clarify HTTP response codes considered successful
markushi Apr 7, 2025
9e6b076
Apply suggestions from code review
markushi Apr 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions develop-docs/sdk/expected-features/index.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,16 +232,17 @@ This feature is also known as 'Offline Caching'.

Write events to disk before attempting to send, so that they can be retried in the event of a temporary network failure. Needs to implement a cap on the number of stored events. This is mostly useful on mobile and desktop(e.g: laptop) apps, where stable connectivity is often not available.

#### Dealing with failures
### Dealing with network failures

It's important to note that retry is only considered in the event of a network failure. For example:
A `HTTP 2xx` response status code response from Sentry is considered a successful send. It's important to note that retry is only considered in the event of a network failure. For example:

* Connection timeout
* DSN resolution failure
* Connection reset by peer

Other failures, like those caused by processing the file in the SDK itself, the payload should be discarded since those are likely to end up on an endless retry.
If the event reached Sentry and a HTTP response status code was received, even in the event of a `500` response, the event should be discarded.
If the event reached Sentry and a HTTP response status code was received, even in the event of a `HTTP 500` status code, the event should be discarded.


#### Additional capabilities

Expand Down