Skip to content

Conversation

@markushi
Copy link
Member

@markushi markushi commented Apr 7, 2025

DESCRIBE YOUR PR

As part of getsentry/team-sdks#109 (comment) we want to clarify that any HTTP 2xx should be treated as succesfull.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

@vercel
Copy link

vercel bot commented Apr 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2025 11:57am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Apr 23, 2025 11:57am
sentry-docs ⬜️ Ignored (Inspect) Visit Preview Apr 23, 2025 11:57am

Copy link
Contributor

@coolguyzone coolguyzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🛳️

@markushi markushi enabled auto-merge (squash) April 23, 2025 11:49
@markushi markushi merged commit fdd6644 into master Apr 23, 2025
14 checks passed
@markushi markushi deleted the markushi/chore/sdk-envelope-response-codes branch April 23, 2025 11:57
bitsandfoxes pushed a commit that referenced this pull request Apr 24, 2025
* chore(sdk): Clarify HTTP response codes considered successful

* Apply suggestions from code review

Co-authored-by: Alex Krawiec <[email protected]>

---------

Co-authored-by: Alex Krawiec <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators May 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants