-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
ref(platform): Update sidebar components structure #13307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This was a bit tricky to follow/understand, and should hopefully be clearer now.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Bundle ReportChanges will decrease total bundle size by 600 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-server-cjsAssets Changed:
Files in
view changes for bundle: sentry-docs-client-array-pushAssets Changed:
|
chargome
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you!
This was a bit tricky to follow/understand, and should hopefully be clearer now.
I noticed this while trying to change some sidebar styling, that this is pretty hard to reason about.
Now, this PR:
DynamicNavthat were not actually used anymore at allwithChevronandcollapseinto a singlecollapsibleproperty, as we always use this together anyhow (except in one place in develop docs, where IMHO it is fine to also be consistent...)DynamicNavhandling if noparentNodeexists - this is never the case as far as I can tell, we can just bail out in this theoretical case.