feat(js): Update product pages to drop Set up prefix in navigation
#13351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Bundle ReportChanges will increase total bundle size by 14 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-client-array-pushAssets Changed:
view changes for bundle: sentry-docs-server-cjsAssets Changed:
Files in
|
Also make sure to use this in breadcrumbs instead of the actual page heading.
mydea
force-pushed
the
fn/js-navigation-labels
branch
from
28d958f to
be2b4f8
Compare
Contributor
|
@mydea - I'm wondering about doing this for at least Python as well before merging this change. I should have some time next week to work on it if you don't get to it first. |
sfanahata
approved these changes
Apr 11, 2025
Contributor
sfanahata
left a comment
sfanahata
left a comment
There was a problem hiding this comment.
Looks good! Thanks for this one.
coolguyzone
approved these changes
Apr 14, 2025
Contributor
coolguyzone
left a comment
coolguyzone
left a comment
There was a problem hiding this comment.
Thanks! This feature will be very useful. Code looks good to me, works on preview.
chargome
approved these changes
Apr 15, 2025
Member
Author
|
Done fully here instead: #13392 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also make sure to use this in breadcrumbs instead of the actual page heading.
Note that the pages themselves keep their "Set up XXX" heading, which makes sense IMHO.